[publication] Add columns to publications #7361

pierre-p-s · 2021-03-01T17:24:27Z

Brief summary of changes

Added 3 data columns to the publication module:
- Project,
- Date published,
- Journal,
- link and
- publishing status (dropdown menu with: in progress or published)

Testing instructions (if applicable)

In publication module, propose a project entering data in the new columns
After the project is proposed, go into the browse tab and click on the project. Check that the new columns appear and that the data matches the one you just entered

Link(s) to related issue(s)

Solves a CCNA issue: https://github.com/aces/CCNA/issues/4424

kongtiaowang · 2021-03-02T14:54:21Z

rebase after #7369

pierre-p-s · 2021-03-02T15:01:54Z

rebase after #7369

Thanks.

kongtiaowang · 2021-03-10T15:37:28Z

The schema SQL file and RB_file need to be modified as well.

Loris/SQL/0000-00-00-schema.sql

Line 2148 in 1abab54

CREATE TABLE `publication` (

pierre-p-s · 2021-03-10T19:54:25Z

The schema SQL file and RB_file need to be modified as well.

Loris/SQL/0000-00-00-schema.sql

Line 2148 in 1abab54

CREATE TABLE `publication` (

I rebased and added the changes to the schema. Not sure what I should do about the RB_Files

driusan · 2021-03-10T20:47:06Z

This should be going to the main branch

kongtiaowang · 2021-03-11T15:26:11Z

Please ignore the RB files. It doesn't change the schema.

pierre-p-s · 2021-03-11T15:48:07Z

I cant seem to be able to run make dev on aces/main. I am getting the error attached below. If someone knows how to fix it please let me know.

kongtiaowang · 2021-03-17T15:23:03Z

@pierre-p-s try: "make clean" then "make dev", it may solve your issue. Good luck.

pierre-p-s · 2021-03-17T16:03:24Z

@pierre-p-s try: "make clean" then "make dev", it may solve your issue. Good luck.

It did not work for me

ridz1208 · 2021-03-17T16:30:19Z

@pierre-p-s what versions of node and npm do you have ?

node -v
npm -v

pierre-p-s · 2021-03-17T16:33:56Z

node -v : v12.16.2

npm -v : 6.14.4

Do I need to update them?

ridz1208 · 2021-03-17T16:35:19Z

Do I need to update them?

I don't think so I have the same versions and it works for me

driusan · 2021-03-19T19:54:16Z

have you tried deleting vendor and node_modules before running make dev?

pierre-p-s · 2021-03-19T20:22:16Z

have you tried deleting vendor and node_modules before running make dev?

Yes

kongtiaowang

LGTM

pierre-p-s · 2021-04-28T16:12:23Z

We found a bug related to this. Fixing it now

driusan · 2021-05-03T18:00:46Z

@pierre-p-s is this still needs work or can @kongtiaowang re-review it?

pierre-p-s · 2021-05-03T18:22:18Z

@driusan Sorry forgot to delete the needs work tag. Yes it s ready for review

kongtiaowang · 2021-05-08T17:01:56Z

After the 4th commit, the publication module can't save a publication into the database.

SQL/0000-00-00-schema.sql

driusan · 2021-06-08T15:40:25Z

modules/publication/ajax/FileUpload.php

@@ -66,9 +70,8 @@ function uploadPublication() : void
    $leadInvID = $db->pselectOne(
        'SELECT PublicationCollaboratorID '.
        'FROM publication_collaborator '.
-        'WHERE Name = :n OR Email = :e',
+        'WHERE Email = :e',


I think this should be a different pull request if it's a different feature/bug.

Reverted, will send a new PR

modules/publication/jsx/projectFields.js

modules/publication/jsx/publicationIndex.js

modules/publication/php/publication.class.inc

pierre-p-s · 2021-06-18T15:57:43Z

Addressed comments and added a new field: Project.

ridz1208 · 2022-10-05T20:49:14Z

@driusan this can be merged if you take a quick look at it

pierre-p-s added the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Mar 1, 2021

kongtiaowang added Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch and removed Needs Rebase PR contains conflicts with the current target branch or was issued to the wrong branch labels Mar 1, 2021

pierre-p-s force-pushed the 2021_03_01_Publication_Add_Columns branch from f7f23cd to 649300f Compare March 10, 2021 19:45

pierre-p-s removed the "Help! I don't understand Travis!" PR is having a beef with TRAVIS. Someone needs to help label Mar 10, 2021

pierre-p-s added 3 commits March 11, 2021 10:20

[publication] Add columns to publications

1414fd8

Minor changes

084a395

Added to SQl schema

5913c9f

pierre-p-s force-pushed the 2021_03_01_Publication_Add_Columns branch from e327977 to 5913c9f Compare March 11, 2021 15:21

pierre-p-s changed the base branch from 23.0-release to main March 11, 2021 15:22

Fix typo

a755cbb

kongtiaowang approved these changes Apr 28, 2021

View reviewed changes

kongtiaowang added the Passed Manual Tests PR has undergone proper testing by at least one peer label Apr 28, 2021

pierre-p-s removed the Passed Manual Tests PR has undergone proper testing by at least one peer label Apr 28, 2021

kongtiaowang added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label Apr 28, 2021

pierre-p-s added 2 commits April 28, 2021 17:04

Fixes edit bug, add elements to browse, adds rules and fixes camel case

0ca2c6e

Fix test suite

d0ac80d

pierre-p-s removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label May 3, 2021

kongtiaowang added the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label May 8, 2021

Solving bug

4b733b9

pierre-p-s removed the Needs Work PR awaiting additional changes by the author or contains issues that the author needs to fix label May 13, 2021

cmadjar assigned driusan Jun 8, 2021

cmadjar added the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Jun 8, 2021

driusan requested changes Jun 8, 2021

View reviewed changes

driusan reviewed Jun 8, 2021

View reviewed changes

modules/publication/jsx/projectFields.js Outdated Show resolved Hide resolved

Addressing Dave's comments

13761d3

pierre-p-s removed the Discussion Required PR or issue awaiting the resolution of a discussion between all involved parties label Jun 10, 2021

pierre-p-s closed this Jun 10, 2021

pierre-p-s reopened this Jun 10, 2021

phpcs

d9fa891

driusan requested changes Jun 15, 2021

View reviewed changes

modules/publication/jsx/publicationIndex.js Outdated Show resolved Hide resolved

modules/publication/php/publication.class.inc Outdated Show resolved Hide resolved

Addressing Comment and adding project field

b7afc47

pierre-p-s added 4 commits June 18, 2021 12:03

Fix lint

2f2f3ae

Lint issue

78c9077

Phan

667e707

Phan again

5af7183

driusan merged commit 663536d into aces:main Oct 14, 2022

ridz1208 added this to the 25.0.0 milestone Mar 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[publication] Add columns to publications #7361

[publication] Add columns to publications #7361

pierre-p-s commented Mar 1, 2021 •

edited

kongtiaowang commented Mar 2, 2021

pierre-p-s commented Mar 2, 2021

kongtiaowang commented Mar 10, 2021 •

edited

pierre-p-s commented Mar 10, 2021

driusan commented Mar 10, 2021

kongtiaowang commented Mar 11, 2021

pierre-p-s commented Mar 11, 2021 •

edited

kongtiaowang commented Mar 17, 2021

pierre-p-s commented Mar 17, 2021

ridz1208 commented Mar 17, 2021

pierre-p-s commented Mar 17, 2021

ridz1208 commented Mar 17, 2021

driusan commented Mar 19, 2021

pierre-p-s commented Mar 19, 2021

kongtiaowang left a comment

pierre-p-s commented Apr 28, 2021

driusan commented May 3, 2021

pierre-p-s commented May 3, 2021

kongtiaowang commented May 8, 2021

driusan Jun 8, 2021

pierre-p-s Jun 10, 2021

pierre-p-s Jun 10, 2021

pierre-p-s commented Jun 18, 2021

ridz1208 commented Oct 5, 2022

[publication] Add columns to publications #7361

[publication] Add columns to publications #7361

Conversation

pierre-p-s commented Mar 1, 2021 • edited

Brief summary of changes

Testing instructions (if applicable)

Link(s) to related issue(s)

kongtiaowang commented Mar 2, 2021

pierre-p-s commented Mar 2, 2021

kongtiaowang commented Mar 10, 2021 • edited

pierre-p-s commented Mar 10, 2021

driusan commented Mar 10, 2021

kongtiaowang commented Mar 11, 2021

pierre-p-s commented Mar 11, 2021 • edited

kongtiaowang commented Mar 17, 2021

pierre-p-s commented Mar 17, 2021

ridz1208 commented Mar 17, 2021

pierre-p-s commented Mar 17, 2021

ridz1208 commented Mar 17, 2021

driusan commented Mar 19, 2021

pierre-p-s commented Mar 19, 2021

kongtiaowang left a comment

Choose a reason for hiding this comment

pierre-p-s commented Apr 28, 2021

driusan commented May 3, 2021

pierre-p-s commented May 3, 2021

kongtiaowang commented May 8, 2021

driusan Jun 8, 2021

Choose a reason for hiding this comment

pierre-p-s Jun 10, 2021

Choose a reason for hiding this comment

pierre-p-s Jun 10, 2021

Choose a reason for hiding this comment

pierre-p-s commented Jun 18, 2021

ridz1208 commented Oct 5, 2022

pierre-p-s commented Mar 1, 2021 •

edited

kongtiaowang commented Mar 10, 2021 •

edited

pierre-p-s commented Mar 11, 2021 •

edited