[Filter] Fix Menu Filter logic to recognise sex for exact match #7498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridz1208
added
the
Bug
|
@jstirling91 can you verify that this fixes your issue ? I have no way to test it |
jstirling91
approved these changes
Jun 29, 2021
jstirling91
added
the
Passed Manual Tests
|
I can merge this, but.. where is this used? Aren't all the menu filters converted to React and done client-side now? |
|
@driusan I think during the meeting jordan mentioned it's break overridden and project modules not yet upgraded to react |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a missing change from #3897 where gender was changed to sex but the substring query was not altered accordingly.
Fixes #7492