Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[candidate_list] Remove meaningless Latest_Visit_Status column #7759

Merged
merged 2 commits into from
Oct 14, 2022
Merged

[candidate_list] Remove meaningless Latest_Visit_Status column #7759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fa67c6
[candidate_list] Remove meaningless Latest_Visit_Status column
driusan Oct 29, 2021
a1c5afe
Remove references in tests
driusan Nov 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 0 additions & 16 deletions modules/candidate_list/jsx/candidateListIndex.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,22 +306,6 @@ class CandidateListIndex extends Component {
},
},
},
{
'label': 'Latest Visit Status',
'show': true,
'filter': {
name: 'latestVisitStatus',
type: 'select',
hide: this.state.hideFilter,
options: {
'Not Started': 'Not Started',
'Screening': 'Screening',
'Visit': 'Visit',
'Approval': 'Approval',
'Recycling Bin': 'Recycling Bin',
},
},
},
{
'label': 'Project',
'show': true,
Expand Down
1 change: 0 additions & 1 deletion modules/candidate_list/php/candidatelistrowprovisioner.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ class CandidateListRowProvisioner extends \LORIS\Data\Provisioners\DBRowProvisio
c.Sex,
COUNT(DISTINCT s.Visit_label) AS VisitCount,
IFNULL(MIN(feedback_bvl_thread.Status+0),0) AS Feedback,
max(s.Current_stage) AS LatestVisitStatus,
p.Name AS RegistrationProject,
c.RegistrationCenterID,
c.RegistrationProjectID
Expand Down
1 change: 0 additions & 1 deletion modules/candidate_list/test/TestPlan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
[ ] Biological Sex
[ ] Number of visits
[ ] Date of birth
[ ] Latest Visit Status
[ ] Feedback
[Automation Testing]
9. Click "Clear Form" and ensure filters are reset to same state as #2.
Expand Down
12 changes: 0 additions & 12 deletions modules/candidate_list/test/candidate_listTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ class CandidateListTestIntegrationTest extends LorisIntegrationTestWithCandidate
static $dob = 'input[name="DoB"]';
static $visitCount = 'input[name="visitCount"]';
static $feedback = 'select[name="feedback"]';
static $lastVisit = 'select[name="latestVisitStatus"]';
static $edc = 'input[name="edc"]';


Expand Down Expand Up @@ -155,10 +154,6 @@ function testCandidateListAdvancedOptionsAppear()
$this->assertEquals("input", $edcOptions->getTagName());
// Not currently done
//$this->assertEquals("date",$edcOptions->getAttribute("type"));
$latestVisitOptions = $this->safeFindElement(
WebDriverBy::Name("latestVisitStatus")
);
$this->assertEquals("select", $latestVisitOptions->getTagName());
$feedbackOptions = $this->safeFindElement(
WebDriverBy::Name("feedback")
);
Expand Down Expand Up @@ -286,13 +281,6 @@ function testFilters()
"closed",
'11 rows'
);
$this->_filterTest(
self::$lastVisit,
self::$display,
self::$clearFilter,
"Visit",
'413'
);
$this->_filterTest(
self::$edc,
self::$display,
Expand Down