[tools & instruments] Fix DB calls #8162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do these need to be fixed in the latest release or just on main? |
|
@driusan issue does exist on 24.1-release .. should i change branches? |
|
yes, please. |
zaliqarosli
force-pushed
the
2022-09-01-FixDatabaseCalls
branch
from
28ab9c3
to
1977d17
Compare
driusan
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Similar PR to #8128, assign_missing_instruments and instruments themselves got missed in #8074
Testing instructions (if applicable)
tools/assign_missing_instruments.phpand see error.Link(s) to related issue(s)