Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imaging Uploader] Replace 'MINC' string by 'Files' in the imaging uploader column since imaging files created and inserted are not necessarily MINC files anymore #8205

Merged

Conversation

cmadjar
Copy link
Collaborator

@cmadjar cmadjar commented Oct 31, 2022

Brief summary of changes

MINC is hardcoded in the column labels specifying the number of files created by the pipeline and the number of files inserted into the imaging browser. Since LORIS supports insertion of MINC files and NIfTI files only, it does not make sense to show 'Number of MINC created' and 'Number of MINC inserted' in the imaging uploader columns header when the files created are NIfTI files...

Replaced MINC string by Files in those columns to make it more generic to all project workflows.

Testing instructions

  1. Checkout this branch and run make
  2. Check that the last two columns of the imaging uploader table are called 'Number of Files Created' and 'Number of Files Inserted'
  3. Make sure that the column 'Number of Files Created' shows the number of violated scans if 'Number of Files Created' > 'Number of Files Inserted'

@cmadjar cmadjar added the 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 label Oct 31, 2022
@driusan driusan merged commit 0d9aada into aces:24.1-release Nov 4, 2022
@ridz1208 ridz1208 added this to the 24.1.1 milestone Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants