New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new_timepoint] only show null language option when multiple exist #8253
[new_timepoint] only show null language option when multiple exist #8253
Conversation
I am having trouble understanding the errors in the test suite. Everything working fine on front end in my manual tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with only 1 language, the field still displays
Sorry Zaliqa, I fixed the PR title & description. The PR was modified so that the field still displays but a null option is only present when multiple languages exist. |
for step 1 "Check that one or less languages exists in the language table", whats the intended functionality if there are 0 languages in the language table? |
This is a mistake - there should be at least one language. Fixed step 1 |
@CamilleBeau okayy looks good! could you add the changes in this PR to the Testplan.md? and then i'll approve! |
…CamilleBeau/Loris into 2022-12-05_null_language_option
Done! |
Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
Brief summary of changes
In this PR, the language drop down for timepoints is only contains a null option when creating a new timepoint if there are more than one languages to choose from in the language table. Otherwise the field automatically selected.
Testing instructions (if applicable)
Link(s) to related issue(s)