Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new_timepoint] only show null language option when multiple exist #8253

Merged
merged 9 commits into from Dec 20, 2022

Conversation

CamilleBeau
Copy link
Contributor

@CamilleBeau CamilleBeau commented Dec 5, 2022

Brief summary of changes

In this PR, the language drop down for timepoints is only contains a null option when creating a new timepoint if there are more than one languages to choose from in the language table. Otherwise the field automatically selected.

  • Have you updated related documentation?

Testing instructions (if applicable)

  1. Check that exactly one language exists in the language table
  2. Create a new timepoint
  3. Make sure that the language drop down does not contain a null option & that you are successfully able to create the timepoint with the one option automatically selected
  4. Add a language to the language table to have 2 or more
  5. Create another timepoint and make sure that the language drop down is displayed with a null option
  6. Check that the language field is required in this case, and that you can not save without it
  7. If the language selection is made, make sure that you are able to save the timepoint properly

Link(s) to related issue(s)

@CamilleBeau CamilleBeau reopened this Dec 12, 2022
@CamilleBeau
Copy link
Contributor Author

I am having trouble understanding the errors in the test suite. Everything working fine on front end in my manual tests.

Copy link
Contributor

@zaliqarosli zaliqarosli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with only 1 language, the field still displays

@CamilleBeau CamilleBeau changed the title [new_timepoint] Only display language when multiple exist [new_timepoint] only show null language option when multiple exist Dec 19, 2022
@CamilleBeau
Copy link
Contributor Author

with only 1 language, the field still displays

Sorry Zaliqa, I fixed the PR title & description. The PR was modified so that the field still displays but a null option is only present when multiple languages exist.

@zaliqarosli
Copy link
Contributor

for step 1 "Check that one or less languages exists in the language table", whats the intended functionality if there are 0 languages in the language table?

@CamilleBeau
Copy link
Contributor Author

for step 1 "Check that one or less languages exists in the language table", whats the intended functionality if there are 0 languages in the language table?

This is a mistake - there should be at least one language. Fixed step 1

@zaliqarosli
Copy link
Contributor

@CamilleBeau okayy looks good! could you add the changes in this PR to the Testplan.md? and then i'll approve!

@CamilleBeau
Copy link
Contributor Author

@CamilleBeau okayy looks good! could you add the changes in this PR to the Testplan.md? and then i'll approve!

Done!

Co-authored-by: Zaliqa <zaliqa.rosli@mcin.ca>
@zaliqarosli zaliqarosli added the Passed Manual Tests PR has undergone proper testing by at least one peer label Dec 20, 2022
@driusan driusan merged commit 13b3f8a into aces:main Dec 20, 2022
@ridz1208 ridz1208 added this to the 25.0.0 milestone Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Manual testing] - New timepoint
5 participants