[issue tracker] Fix emailing bug found in HBCD #8300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
the
Bug
|
@cmadjar who can review this from HBCD ? |
|
@ridz1208 the bug is not HBCD specific. It is LORIS wide. No idea who in HBCD could review this PR. Maybe @sruthymathew123? |
|
@CamilleBeau if CCNA uses the module can you assign this to someone on your team? |
CamilleBeau
approved these changes
Jan 30, 2023
|
Just tested and reviewed - Working well for me and code looks good! |
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Mar 6, 2023
The logic to send emails to watchers and assignee was off. Watchers ended up receiving emails that an issue was assigned to them even though it was not. With this bug fix: - an "issue assigned" email is sent to new assignees - a 'issue changed' email is sent to watchers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
The logic to send emails to watchers and assignee was off. Watchers ended up receiving emails that an issue was assigned to them even though it was not. With this bug fix: