[issue_tracker] Display attachments #8346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CamilleBeau
added
the
Feature
GeorgeMurad
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
@LeighMac @CamilleBeau I have tested the new feature and it works perfectly.
|
@CamilleBeau can't merge because of a conflict in the changelog, can you rebase? |
Done! Sorry abou that. |
driusan
reviewed
Mar 28, 2023
| {regexImg.test(item.mime_type) ? | ||
| (<img | ||
| src={this.props.baseURL + | ||
| '/issue_tracker/Attachment' + |
There was a problem hiding this comment.
I don't think this is a very nice URL. It would be better if it was routed as something like https://example.com/issue_tracker/issue/1234/attachments/filename.pdf but I'm not gonna block over it because the endpoint is already there.
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This PR was originally made by Pierre Pac-Soo on CCNA here. The changes allow image attachments to be displayed in the issue instead of having to download.
Testing instructions (if applicable)
Link(s) to related issue(s)