-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[imaging browser] Fix download of JSON, Bval and Bvec files when they are on s3 #8354
Merged
driusan
merged 24 commits into
aces:24.1-release
from
cmadjar:fix_imaging_browser_json_downloads_when_file_on_s3
Feb 13, 2023
Merged
Changes from 5 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
a586f1e
add download of BIDS JSON, NIfTI + Bval + Bvec to the API so it can b…
cmadjar 4716737
use API links to download from view session imaging browser
cmadjar c40102c
fix phan
cmadjar 4f3ea96
fix phan
cmadjar fdb6512
create one class to do them all
cmadjar 8bf64cf
move switch to the constructor of the class
cmadjar 46aa398
fix phpcbf
cmadjar e18586b
fix phpcbf
cmadjar 998b34f
fix phpcbf
cmadjar d0eb91f
fix phpcbf
cmadjar 03a3d42
fix phpcbf
cmadjar 8c1a236
Xavier's feedback I missed
cmadjar 3f86d70
revert last commit
cmadjar 1cdce27
Xavier's feedback after a good night sleep
cmadjar 614b334
remove all ->_check variables
cmadjar 0de005e
remove unecessary extra comma
cmadjar c1e92b2
remove unecessary extra comma
cmadjar a76d31c
Xavier's feedback
cmadjar a24a5da
Make Phan happy
cmadjar f6e54ff
PSR
cmadjar 4fe033a
Phan
cmadjar 55c8dfd
Phan
cmadjar 309f52b
Dave's comment
cmadjar 27c14a5
Dave's comment
cmadjar File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aren't thumbnails intended to be displayed inline?
(It looks like the code already had an attachment Content-Disposition, so I guess it doesn't matter..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the thumbnail is mainly used to be displayed in the imaging browser but it was already available for download in the API and that is the file I used to base all the other classes so I kept it. @driusan does it answer your question?