[imaging browser] Fix Human dangling out of nowhere #8363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmadjar
added
Bug
|
@driusan @ridz1208 I sent this to 24.1-release as this corrects a bug that was introduced in LORIS 24. The one with "Human" under T1W QC. I noticed that on HBCD last week and the same week @thomasbeaudry updated his LORIS instance to 24 and noticed it as well. So this should probably go in the next bug fix. |
cmadjar
added
the
Needs Work
driusan
reviewed
Feb 9, 2023
modules/imaging_browser/php/imagingbrowserrowprovisioner.class.inc
Outdated
Show resolved
Hide resolved
cmadjar
removed
the
Needs Work
nicolasbrossard
approved these changes
Feb 14, 2023
zaliqarosli
pushed a commit
to zaliqarosli/Loris
that referenced
this pull request
Mar 6, 2023
When downloading the imaging browser list data as CSV, there are dangling "Human"s in a column with no header associated to it. Resolves aces#7876.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
This resolves #7876.
When downloading the imaging browser list data as CSV, there are dangling "Human"s with no header associated to it as can be seen below:
This PR corrects the issue so that the Human's have a proper header. It also resolves the Human being placed under T1 QC status for example when no scan types are selected to be displayed in the Config module under the Imaging Module tab. See screenshot below for the bug that was introduced in 24:
In addition, there is currently a bug with the order of the QC status displayed in the imaging browser and the headers in the table. This PR also fix the bug.
As for the content of the CSV showing more columns than what is being displayed, this is a LORIS wide behaviour, not an actual bug.