[document_repository] Fix download path to correct user

[zaliqarosli]

Brief summary of changes

• Have you updated related documentation?

Testing instructions (if applicable)

1. Checkout branch 24.1-release and run make dev or npm run compile
2. Upload a file as User 1 (i.e. your own). Download that file once uploaded and confirm that the download worked.
3. Login as User 2 (i.e. admin). Try to download the same file and confirm that the download fails.
4. Go to the dashboard and click on one of the items in the 'Document Repository Notifications' widget. Confirm that the download fails.
5. Checkout this PR branch. Download the same file as User 2 and confirm that the download worked
6. Go to the dashboard and click on one of the items in the 'Document Repository Notifications' widget. Confirm that the download worked.

Link(s) to related issue(s)

• Resolves # (Reference the issue this fixes, if any.)

[ridz1208]

@zaliqarosli @charliehenrib I'm confused how this is not a much much bigger issue. Shouldn't this prevent pretty much anyone from downloading any file that they didnt upload themselves ??

[ridz1208]

@CamilleBeau do you have a VM where you can pull this for charlie to test ?

[CamilleBeau]

@CamilleBeau do you have a VM where you can pull this for charlie to test ?

Yes I will pull this onto our dev VM

[zaliqarosli]

@ridz1208 i think it depends on what projects have this bug cz it was fixed for a certain version, and then the code refactored that re-introduced it. i know that it was something I had to fix for COPN on 21.. but it had already been fixed for a later version

[charliehenrib]

@CamilleBeau @ridz1208 I followed the testing steps above and it works exactly as described. Is there a passed manual testing label that I should add?

[zaliqarosli]

@driusan i fixed it to what you suggested. can you re-review?

[driusan]

Code looks good to me. @charliehenrib can you re-test it?

[charliehenrib]

I retested and it works as it should :)