Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form.js] Add support for vertical Radio button groups #8414

Merged
merged 2 commits into from Mar 17, 2023

Conversation

driusan
Copy link
Collaborator

@driusan driusan commented Feb 24, 2023

This adds a vertical=true/false attribute to our wrapper. The option toggles whether the radio options are displayed vertically or horizontally on the page.

This adds a vertical=true/false attribute to our <RadioElement>
wrapper. The option toggles whether the radio options are displayed
vertically or horizontally on the page.
@driusan driusan added Feature PR or issue introducing/requiring at least one new feature javascript Pull requests that update Javascript code labels Feb 24, 2023
@laemtl laemtl added this to the 25.0.0 milestone Feb 28, 2023
@laemtl laemtl self-assigned this Mar 7, 2023
@laemtl laemtl assigned jeffersoncasimir and unassigned laemtl Mar 14, 2023
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended!

jsx/Form.js Outdated Show resolved Hide resolved
@jeffersoncasimir jeffersoncasimir added the Passed Manual Tests PR has undergone proper testing by at least one peer label Mar 16, 2023
Co-authored-by: jeffersoncasimir <15801528+jeffersoncasimir@users.noreply.github.com>
@driusan driusan merged commit 8fe5132 into aces:main Mar 17, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR or issue introducing/requiring at least one new feature javascript Pull requests that update Javascript code Passed Manual Tests PR has undergone proper testing by at least one peer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants