[API] Using isAccessibleBy on candidate endpoint #8824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlecours
added
the
Security
ridz1208
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Approving although I realize now that it may be redundant (still not a bad idea though) because all subendpoints (visits) already have the isaccessible by and both hendleGET and handlePUT check for user sites and projects.
I think it's the ad-hoc locations of the site/project checks that is a bit confusing.
Either way the redundancy is welcome here
|
|
interesting. I'll change /candidate/$candid |
|
@driusan passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.