Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Libraries] Feedback panel - fix fieldnames setting #8848

Merged
merged 2 commits into from
Aug 16, 2023
Merged

[Libraries] Feedback panel - fix fieldnames setting #8848

merged 2 commits into from
Aug 16, 2023

Conversation

charlottesce
Copy link
Contributor

Brief summary of changes

In the feedback panel for an instrument, the only option in 'Field Name' was 'Across all fields'. This PR changes how the field names for an instrument are fetched so that all of them appear as an option too.

Testing instructions (if applicable)

  1. Go to Candidate -> Access Profile -> choose a participant -> choose a timepoint -> choose an instrument
  2. Open the feedback panel
  3. In Field Name, ensure you can see all the fields of that instrument, and not just 'Across all fields'
  4. Repeat for a different instrument to make sure the appropriate field names appear for different instruments

Note

This is a CCNA override - https://github.com/aces/CCNA/pull/5444

@charlottesce charlottesce added the Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS label Jul 20, 2023
@miladheshmati miladheshmati self-assigned this Aug 10, 2023
@miladheshmati miladheshmati self-requested a review August 10, 2023 15:32
miladheshmati
miladheshmati approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@miladheshmati miladheshmati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Tested successfully on my VM.

@miladheshmati miladheshmati added the Passed Manual Tests PR has undergone proper testing by at least one peer label Aug 10, 2023
@driusan driusan merged commit c6c05ae into aces:24.1-release Aug 16, 2023
9 checks passed
@ridz1208 ridz1208 added this to the 24.1.5 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miladheshmati miladheshmati miladheshmati approved these changes

Assignees

@miladheshmati miladheshmati

Labels
Passed Manual Tests PR has undergone proper testing by at least one peer Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Milestone
24.1.5
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@charlottesce @miladheshmati @driusan @ridz1208 @jeffersoncasimir