Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dict] hotfix add hidden fields to dictionary implementation #8882

Merged
merged 1 commit into from Sep 12, 2023

Conversation

ridz1208
Copy link
Collaborator

Brief summary of changes

Some instruments use hidden fields which were not taken into consideration in this class. This should simply skip over the fields in the dictionary building

@ridz1208 ridz1208 added Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS labels Sep 11, 2023
@ridz1208
Copy link
Collaborator Author

@driusan, @elPreeto STRONGLY approves my changes

@driusan
Copy link
Collaborator

driusan commented Sep 12, 2023

This means that the hidden fields would never be in the data dictionary or queryable in the DQT. Is that the correct logic? What is the use case of "some instruments" using hidden fields?

@ridz1208
Copy link
Collaborator Author

@driusan the only couple usecases I have seen is to pass some data to the front end without it being shown to the user.

@CamilleBeau @laemtl @sruthymathew123 can you do a quick grep for hidden fields in your instruments?

@CamilleBeau
Copy link
Contributor

@driusan the only couple usecases I have seen is to pass some data to the front end without it being shown to the user.

@CamilleBeau @laemtl @sruthymathew123 can you do a quick grep for hidden fields in your instruments?

We don't have any instrument fields hidden in that way.

@sruthymathew123
Copy link
Contributor

@driusan the only couple usecases I have seen is to pass some data to the front end without it being shown to the user.

@CamilleBeau @laemtl @sruthymathew123 can you do a quick grep for hidden fields in your instruments?

@ridz1208 On HBCD, we don't have any instruments with hidden fields. @nicolasbrossard Can you check if anything exists on IBIS?

@driusan driusan merged commit 6d6d0d9 into aces:24.1-release Sep 12, 2023
9 checks passed
@ridz1208 ridz1208 added this to the 24.1.5 milestone Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug PR or issue introducing/requiring bug fixes (not mutually exclusive with the Feature label) Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants