Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[behavioural_qc] fixes visitLevel feedback not showing up. #8900

Conversation

racostas
Copy link
Contributor

@racostas racostas commented Sep 27, 2023

Brief summary of changes

The visit Level feedback was included as part of the formatColumn() function in the BehaviouralFeedback class file /modules/behavioural_qc/jsx/tabs_content/behaviouralFeedback.js

Testing instructions (if applicable)

  1. Go to MainMenu-> Clinical -> Behavioural Quality Control.
  2. Then go to the Behavioural Feedback tab.
  3. All the columns should show properly now.
  4. The links should be also properly working.

image

Link(s) to related issue(s)

@racostas racostas added the Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS label Sep 27, 2023
@regisoc
Copy link
Contributor

regisoc commented Dec 12, 2023

@racostas Not sure how to test that, how do we add a new visit level feedback?
When using make testdata raisinbread does not seem to have visit level feedback.

@regisoc
Copy link
Contributor

regisoc commented Dec 12, 2023

Nvm @racostas, @charliehenrib showed me the sneaky small icon I did not know. Thanks!

Copy link
Contributor

@regisoc regisoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

Before
image

After
image

@driusan driusan merged commit 7d8f81d into aces:24.1-release Jan 11, 2024
9 checks passed
@ridz1208 ridz1208 added this to the 24.1.6 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[behavioural_qc] Behavioural feedback tab - Feedback Level column contains empty entries
4 participants