Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[media] fixes issue when media module try to instantiate a non existing instrument. #8903

Conversation

racostas
Copy link
Contributor

Brief summary of changes

A try catch block was added to prevent the module to break if for any reason one of the instruments could not be instantiated. Pleas refer to issue #8902

Testing instructions (if applicable)

  1. Having the pre-requisites described in [media] Error 404 is shown when media module trays to instantiate a non existing instrument.  #8902
  2. Go to MainMenu->Clinical->Media
  3. The module should load now
  4. The failing to instantiate instruments should be logged in the error-log

Link(s) to related issue(s)

@racostas racostas added Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS 24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 labels Sep 29, 2023
@driusan
Copy link
Collaborator

driusan commented Oct 2, 2023

Why can the instrument not be instantiated? That sounds like a deeper problem with the instrument that should be fixed.

@ridz1208
Copy link
Collaborator

ridz1208 commented Oct 2, 2023

@racostas I like the try catch, but I think other than the error log maybe a warning alert on the browser saying something like "Uploads to instrument BLA were not loaded due to an error" something along these lines so that it doesnt go unnoticed

@driusan driusan merged commit d7a599b into aces:24.1-release Dec 5, 2023
9 checks passed
@ridz1208 ridz1208 added this to the 24.1.6 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
24.0.0-bugs Issues or bug fix PRs that were raised during the testing of release 24.0.0 Priority: Projects PR or issue is a priority for at least one project and should be a higher priority for LORIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[media] Error 404 is shown when media module trays to instantiate a non existing instrument.
3 participants