Skip to content

Commit

Permalink
Make INDENT configurable
Browse files Browse the repository at this point in the history
  • Loading branch information
Ace Suares committed Aug 17, 2015
1 parent 70d6035 commit 703b907
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 17 deletions.
44 changes: 28 additions & 16 deletions lib/app/views/inline_forms/_show.html.erb
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
<div class="row">
<div class='medium-1 large-1 column'>
&nbsp;
</div>
<div class='small-11 column'>
<% if (INLINE_FORMS_SHOW_INDENT rescue true) %>

This comment has been minimized.

Sign in to view

Copy link
@kamk

kamk Oct 19, 2015

antipattern:
exception handling used for flow control

feedback:
You may want to check for constant presence somewhat like this:
InlineForms.const_defined?(:INLINE_FORMS_SHOW_INDENT) ? INLINE_FORMS_SHOW_INDENT : true


created on antipattern.io
<div class='medium-1 large-1 column'>
&nbsp;
</div>
<div class='small-11 column'>
<% else %>
<div class='small-12 column'>
<% end %>
<% unless @skip %>
<div class="row object_presentation">
<div class="small-11 column object_presentation">
Expand Down Expand Up @@ -35,15 +39,19 @@
</div>
</div>
<div class="row <%= cycle('odd', 'even') %>">
<div class='medium-1 large-1 column'>
&nbsp;
</div>
<div id="<%= css_class_id -%>" class='small-11 column' >
<% if (INLINE_FORMS_TREE_INDENT rescue true) %>
<div class='medium-1 large-1 column'>
&nbsp;
</div>
<div class='small-11 column'>
<% else %>
<div id="<%= css_class_id -%>" class='small-12 column' >
<% end %>
<%= render :partial => "inline_forms/tree",
:locals => { :parent_class => @object.class,
:parent_id => @object.id,
:attribute => attribute } %>
</div>
</div>
</div>
<% else %>
<% if form_element == :associated -%>
Expand All @@ -56,16 +64,20 @@
</div>
</div>
<div class="row <%= cycle('odd', 'even') %>">
<div class='medium-1 large-1 column'>
&nbsp;
</div>
<div id="<%= css_class_id -%>" class='small-11 column' >
<%= render :partial => "inline_forms/list",
<% if (INLINE_FORMS_ASSOCIATED_INDENT rescue true) %>
<div class='medium-1 large-1 column'>
&nbsp;
</div>
<div class='small-11 column'>
<% else %>
<div id="<%= css_class_id -%>" class='small-12 column' >
<% end %>
<%= render :partial => "inline_forms/list",
:locals => { :parent_class => @object.class,
:parent_id => @object.id,
:parent_id => @object.id,
:attribute => attribute,
:form_element => form_element } %>
</div>
</div>
</div>
<% else %>
<% if form_element == :has_one %>
Expand Down
2 changes: 1 addition & 1 deletion lib/inline_forms/version.rb
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# -*- encoding : utf-8 -*-
module InlineForms
VERSION = "3.1.2"
VERSION = "3.1.3"
end

0 comments on commit 703b907

Please sign in to comment.