-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python dependencies #38
Comments
@tjjarvinen and @wcwitt -- I just ran into this again. Have you used I wonder whether to bring this to ACEfit so that anything PyCall related will only be loaded if PyCall has already been loaded outside? What do you think? |
I'm trying to understand the precise issue. Is it that ACEfit has PyCall as a dependency in its Project.toml? And this is a problem because someone without Python would have trouble installing PyCall? Looking at https://github.com/JuliaPackaging/Requires.jl I might be missing the point still. |
I have used In short you can use it, by adding function __init__()
@require CUDA="052768ef-5323-5732-b1bb-66c8b64840ba" include("cuda_additions.jl")
end TensorOperations.jl has a more complicated example. You need to explicitly load the package before for it to trigger using PyCall
using ACEfit # now triggers @require |
I think I understand that - and if it will solve @cortner's problem, great - but what confuses me is that So if we did that, wouldn't
still trigger installation of |
Okay, from the Requires.jl readme:
which seems to imply that we wouldn't actually need So this does seem like it would solve the issue. |
I hope this will be addressed by 558adeb. |
I think this is addressed by the PythonCall and MLJ extensions. |
Python dependencies are ok but should not be required. Is this currently guaranteed?
The text was updated successfully, but these errors were encountered: