Skip to content

Support new Int_Array tag; change Byte_Array tag to use byte arrays #2

Closed
wants to merge 4 commits into from

2 participants

@BartMassey

The first commit adds support for the new Int_Array tag introduced with Anvil. The payload is represented in Haskell as a UArray Int32 Int32 .

The second commit changes the Haskell payload representation of Byte_Array to be UArray Int32 Int8 . This latter representation seems better to me for several reasons: Minecraft bytes are supposed to be signed, indexing efficiency should be better, parallels Int_Array.

I am currently working on a Haskell round-tripping translator from Minecraft level files to XML. So far, the translator can properly decode region files in Anvil .mca format, but hasn't yet done anything with that. Thanks huge for Data.NBT, which is a big help on this project!

@acfoltzer
Owner

Should I wait to merge this until you make the further developments discussed in email?

@BartMassey

Sorry--somehow missed your comment here earlier. Yes, please go ahead and pull what I have now, and I'll close out my fork for the moment. I want to finish up with the actual MC stuff before I go back to the NBT.

@ghost
ghost commented Mar 13, 2013

I think this has been fixed by the merging of #5.

@acfoltzer
Owner

Yes, the commits from this pull request were in #5.

@acfoltzer acfoltzer closed this Mar 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.