Support new Int_Array tag; change Byte_Array tag to use byte arrays #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I wait to merge this until you make the further developments discussed in email? |
|
Sorry--somehow missed your comment here earlier. Yes, please go ahead and pull what I have now, and I'll close out my fork for the moment. I want to finish up with the actual MC stuff before I go back to the NBT. |
|
I think this has been fixed by the merging of #5. |
|
Yes, the commits from this pull request were in #5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds support for the new Int_Array tag introduced with Anvil. The payload is represented in Haskell as a UArray Int32 Int32 .
The second commit changes the Haskell payload representation of Byte_Array to be UArray Int32 Int8 . This latter representation seems better to me for several reasons: Minecraft bytes are supposed to be signed, indexing efficiency should be better, parallels Int_Array.
I am currently working on a Haskell round-tripping translator from Minecraft level files to XML. So far, the translator can properly decode region files in Anvil .mca format, but hasn't yet done anything with that. Thanks huge for Data.NBT, which is a big help on this project!