-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added LSPCON driver support and the fix for infinite loop on establishing HDMI connections on IGPU #24
Conversation
Conflicts: WhateverGreen/kern_igfx.cpp WhateverGreen/kern_igfx.hpp
… to HDMI 2.0 output.
…n SKL, KBL and CFL platforms.
Hey, Thanks for this pull-request. Looks quite impressive! It will take me some time to review the code, but all in all it looks reasonably healthy. For the time being
|
Thanks for your reply. Take your time. :)
Yes, in theory it is dangerous, but the property value of
Honestly, I was thinking about adding a property for it before. However, considering the consistency, we could add a property for it. It doesn't hurt. What's your opinion? |
Sorry for the delay, I believe I am done now. I marked the necessary changes inline and mentioned below.
|
Thanks for reviewing my code. I have pushed a new commit.
No, this wasn't intentional. All my private files have permissions 644. I have reverted back to 755 for files in WEG.
Done.
Done. |
By the way, I am considering implementing a helper to retrieve the framebuffer index in a convenient way.
What's your suggestion? |
Something like that could do, as you see fit I guess. |
All in all this looks quite good to me aside the small nuances I added. Please fix them up and I will merge as soon as I can. Thank you so much for this awesome stuff! |
I have pushed new commits to the repo. Thanks again for reviewing my code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, found a small issue I did not spot initially. The rest looks good.
Thank you! Merged! |
This pull request contains two fixes.
Brief Description:
Recent laptops are equipped with a HDMI 2.0 port now. HDMI 2.0 ports on some laptops are routed to IGPU, but Intel IGPU does not provide native HDMI 2.0 output, so OEMs add a chip named LSPCON on the motherboard to convert DP signals to HDMI 2.0 signals.
LSPCON chip has two running modes, and this driver automatically configures the adapter to work in the mode that is capable of converting DP to HDMI 2.0 signals, because some adapters are configured in the firmware to work in the HDMI 1.4 mode by default.
Detailed description could be found at here in kern_igfx.cpp
Brief Description:
This fix is intended to fix the HDMI 2.0 output issue on my Dell XPS 15 laptop and is now succeeded by the LSPCON driver. However, this fix might still be useful for those who want to have limited 2K/4K experience (i.e. 2K@59Hz or 4K@30Hz) with their HDMI 1.4 port.
Detailed description could be found at here in kern_igfx.cpp
Relevant discussion thread: https://www.tonymacx86.com/threads/fix-coffee-lake-intel-uhd-graphics-630-on-macos-mojave-hdmi-output-issue-public-testing-stage.275126/
Articles related to this research is still working in progress.
Thanks,
FireWolf