Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change node_id derivation #193

Closed
t-bast opened this issue Feb 5, 2021 · 0 comments · Fixed by #211
Closed

Change node_id derivation #193

t-bast opened this issue Feb 5, 2021 · 0 comments · Fixed by #211
Milestone
1.0

Comments

@t-bast
Copy link
Member

t-bast commented Feb 5, 2021

It has to be different from the derivation used in the old Phoenix.
@t-bast t-bast added this to the 1.0 milestone Feb 5, 2021
t-bast added a commit that referenced this issue Feb 23, 2021
@t-bast
Change seed derivation purpose
27d3776 
We want to use a different derivation from the current Phoenix app, to ensure
users cannot shoot themselves in the foot by restoring an incompatible seed.

With that change, a user restoring a seed from an old Phoenix wallet will
end up with a different node_id, so its previous channels will not be closed.

That user can then go to the old Phoenix app to move his funds to the new one.

Fixes #193
@t-bast t-bast mentioned this issue Feb 23, 2021
Merged
t-bast added a commit that referenced this issue Feb 24, 2021
@t-bast
Change seed derivation purpose (#211)
7488b0f 
We want to use a different derivation from the current Phoenix app, to ensure
users cannot shoot themselves in the foot by restoring an incompatible seed.

With that change, a user restoring a seed from an old Phoenix wallet will
end up with a different node_id, so its previous channels will not be closed.

That user can then go to the old Phoenix app to move his funds to the new one.

Fixes #193
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Change node ID derivation path ACINQ/lightning-kmp
1 participant
@t-bast