Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex: have a timeout for regex execution #56

Open
auscompgeek opened this issue Oct 12, 2013 · 2 comments
Open

regex: have a timeout for regex execution #56

auscompgeek opened this issue Oct 12, 2013 · 2 comments

Comments

@auscompgeek
Copy link
Contributor

In its current form, the regex plugin is susceptible to ReDoS (as demonstrated by me on @gnustomp's ninjabot instance). A timeout is needed for the execution of the user-provided regex.

It has been suggested that threading may be used to achieve this.

@cyphar
Copy link
Contributor

cyphar commented Nov 16, 2013

@ackwell, does the current codebase use threads for the execution of plugins? Until this happens, we can't do any sleeping of thread, as all execution would halt on the main thread (which we definitely don't want).

@ackwell
Copy link
Owner

ackwell commented Nov 16, 2013

Depends on what the plugin is doing. trigger and on_incoming commands are run inline, timer commands are threaded by Kronos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants