Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

when creating an endpoint via -p, you still get the default clusterDomain endpoint #383

Closed
cjellick opened this issue Jul 29, 2022 · 3 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@cjellick
Copy link
Member

This is the intended behavior, but we wanted to revisit to decide if it was the right move or not

acorn run  -p staging-dns.acrn.io:default --name staging-acorn-dns cjellick/acorn-dns:dev4 

results in

staging-acorn-dns  ...   http://staging-acorn-dns.local.on-acorn.io|http://staging-dns.acrn.io => default:4315 
@cjellick cjellick added this to the OSS-MVP milestone Jul 29, 2022
@ibuildthecloud
Copy link
Member

My logic here was that if you are setting up a public domain the domain might not be immediately available to you might want the default one too. I would opt to keep it but maybe not show it by default the CLI. Add some option in the CLI that just shows the first URL that's not a clusterDomain URL.

@cjellick
Copy link
Member Author

Addressed in #614

@cjellick
Copy link
Member Author

Verified

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants