This repository has been archived by the owner on Mar 16, 2024. It is now read-only.
Fix: Remove PDB for single replica deployment #2481
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrongMonkey
requested review from
thedadams,
njhale,
g-linville,
tylerslaton and
keyallis
Signed-off-by: Daishan Peng <daishan@acorn.io>
StrongMonkey
force-pushed
the
remove-pdb
branch
from
3942ca7
to
9da0484
Compare
thedadams
approved these changes
Feb 17, 2024
| @@ -980,7 +980,10 @@ func ToFunctions(req router.Request, appInstance *v1.AppInstance, tag name.Refer | |||
| } | |||
| result = append(result, perms...) | |||
| } | |||
| result = append(result, sa, dep, pdb.ToPodDisruptionBudget(dep)) | |||
| result = append(result, sa, dep) | |||
| if dep.Spec.Replicas != nil && *dep.Spec.Replicas > 1 { | |||
There was a problem hiding this comment.
nit: here and other places
Suggested change
| if dep.Spec.Replicas != nil && *dep.Spec.Replicas > 1 { | |
| if z.Dereference(dep.Spec.Replicas) > 1 { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This is a title (#1216). Here's an exampleWe should remove PDB for single-replica container. It has casued us issues that prevent pods being evicted and node being consolidated.