Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Call out that issue number should be in PR title #1214

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

cjellick
Copy link
Member

@cjellick cjellick commented Feb 8, 2023

Signed-off-by: Craig Jellick craig@acorn.io

Checklist

  • All relevant issues are referenced in this PR
  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • Commits follow contributing guidance.
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description

@ibuildthecloud
Copy link
Member

ibuildthecloud commented Feb 9, 2023

What is an example of how to put the issue in the title. Just the number? Like Normal commit message #1120

@cjellick
Copy link
Member Author

cjellick commented Feb 9, 2023

Example:
#1199

The upside is that when we generate the changelog in the release notes, it uses PR titles and the issue is there as a link. som examples here:
https://github.com/acorn-io/acorn/releases/tag/v0.5.1

The downside is that when you're looking at a PR, it looks a little cluttered.

Signed-off-by: Craig Jellick <craig@acorn.io>
@cjellick cjellick merged commit 3d1b833 into acorn-io:main Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants