Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

add project validation to project client (#1335) #1344

Merged
merged 1 commit into from Apr 4, 2023
Merged

add project validation to project client (#1335) #1344

merged 1 commit into from Apr 4, 2023

Conversation

jsilverio22
Copy link
Contributor

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in paranthesis, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keyworkds that auto-close issues
    Validate the default project when acorn commands are run #1335
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

@jsilverio22 jsilverio22 force-pushed the validate-project branch 3 times, most recently from 5a4c6e8 to 2c41c15 Compare March 16, 2023 04:38
@jsilverio22 jsilverio22 force-pushed the validate-project branch 4 times, most recently from 45cb47f to 44a9897 Compare March 31, 2023 21:08
@jsilverio22 jsilverio22 marked this pull request as ready for review March 31, 2023 22:26
@jsilverio22 jsilverio22 self-assigned this Apr 3, 2023
yashgiri
yashgiri approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@yashgiri yashgiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thedadams
thedadams approved these changes Apr 4, 2023
View reviewed changes
pkg/project/client.go Show resolved Hide resolved
@jsilverio22 jsilverio22 force-pushed the validate-project branch 2 times, most recently from 04f3352 to 1113e89 Compare April 4, 2023 19:52
cjellick
cjellick reviewed Apr 4, 2023
View reviewed changes
pkg/project/client.go Outdated Show resolved Hide resolved
@jsilverio22
add project validation to project client
3d48f68 
Signed-off-by: Joshua Silverio <joshua@acorn.io>
@jsilverio22 jsilverio22 merged commit 67025af into acorn-io:main Apr 4, 2023
2 checks passed
@jsilverio22 jsilverio22 deleted the validate-project branch April 4, 2023 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cjellick cjellick cjellick approved these changes

@thedadams thedadams thedadams approved these changes

@yashgiri yashgiri yashgiri approved these changes

@iwilltry42 iwilltry42 Awaiting requested review from iwilltry42

@jacobdonenfeld jacobdonenfeld Awaiting requested review from jacobdonenfeld

@g-linville g-linville Awaiting requested review from g-linville

@tylerslaton tylerslaton Awaiting requested review from tylerslaton

Assignees

@jsilverio22 jsilverio22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jsilverio22 @cjellick @thedadams @yashgiri