Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guardedHandlers #48

Closed
canonic-epicure opened this issue Jul 4, 2013 · 2 comments
Closed

guardedHandlers #48

canonic-epicure opened this issue Jul 4, 2013 · 2 comments

Comments

@canonic-epicure
Copy link

Not sure if this is a bug or I'm missing something. According to https://developer.mozilla.org/en-US/docs/SpiderMonkey/Parser_API
TryStatement is always expected to have "guardedHandlers" property.

But on this link https://bugzilla.mozilla.org/show_bug.cgi?id=742612 "guardedHandlers" is marked as optional. The latter document could be outdated though.

So, esprima always adds empty array for "guardedHandlers" should acorn do this too?

Escodegen assumes this property always present in AST.

@marijnh
Copy link
Member

marijnh commented Jul 8, 2013

Indeed. I've updated the code to conform to that document. But I am starting to get worried about the ad-hoc way people are making changes to it. A standard that changes randomly isn't much of a standard.

@canonic-epicure
Copy link
Author

Right, would be great to have some more stability and predictability there. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants