ES6 support

[RReverser]

Working features:

• Unicode Code Point Escape Sequences (\u{ABCDEF}).
• Numeric Literals (octal, binary).
• Arrow Functions.
• Spread Element.
• Classes.
• Destructuring assignments.
• Computed object properties.
• Object methods.
• Shorthand object properties.
• for (... of ...) loops.
• Array Comprehensions.
• Modules. (newest specs)
• Template Strings.
• Generators.
• Generator Comprehensions.

Closes #78.

[vendethiel]

Wow. Nice work.

[marijnh]

Are you okay with a copyright by Marijn Haverbeke and others combined with an AUTHORS file (generated from the git history) that lists all individual contributors, re-generated on every release? Adding everyone to LICENSE individually by hand is going to A) create a noisy license, and B) produce a lot of commit noise.

[marijnh]

Awesome work. See my nitpicks in the comments. (I don't expect you to fix the license thing, I just want your feedback -- I have a similar set-up to generate an AUTHORS file in CodeMirror, and can easily copy that to this repo.)

One thing I was wondering about is why the template string tokenizing is integrated with the normal tokenizing. Wouldn't it make more sense to branch right at the start of readToken, and keep the two apart, since they do very different things?

Are you interested in updating util/walk.js to handle the newly introduced node types? (And maybe acorn_loose.js, if you have another big block of time to burn on this...)

[RReverser]

One thing I was wondering about is why the template string tokenizing is integrated with the normal tokenizing. Wouldn't it make more sense to branch right at the start of readToken, and keep the two apart, since they do very different things?

Was thinking about this, but figured out that it might produce more abstractions where it's not really needed since templates are pretty much like strings, special characters should be treated in the same way and the only differences are 1) not skipping spaces and 2) stopping on ${ inside template string and producing it as a separate token. Let me try to refactor existing solution somewhat later.

Are you interested in updating util/walk.js to handle the newly introduced node types? (And maybe acorn_loose.js, if you have another big block of time to burn on this...)

I'll definitely add types to util/walk.js (probably as separate PR), but not sure yet about "another big block of time" for error-tolerant parser. Let me look into it more precisely so I could answer this question.

[marijnh]

I've merged this. Champagne all around.

Next time, observe the standard git commit message style where you put a short message (<80chars preferably) at the top line, followed by a blank line, and then further details. That way, tools that summarize the commits won't show huge long lines of text (they'll include anything up to the first empty line).

Please create new pull requests for further changes.

[marijnh]

There appears to still be a problem with the Travis setup. I haven't looked into it yet.

[RReverser]

There appears to still be a problem with the Travis setup. I haven't looked into it yet.

Looks like you just didn't turn on support for this repo on the Travis side.

[RReverser]

List of CodeMirror contributors. Updated before every release.

Could you please fix project name in AUTHORS file?

[marijnh]

Done and done. Though Travis seems to be hung on a slow NPM download or something like that.

[RReverser]

Yeah, it has kind of significant delays on free repos, but still better that nothing.