-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES6 support #110
ES6 support #110
Conversation
Added Property type to ObjectExpression properties. Reserved ES6 properties in Property type.
Some more testFail message fixes.
testFail message fixes for object methods.
… method functions (node's location should include arguments).
Wow. Nice work. |
@@ -1,4 +1,5 @@ | |||
Copyright (C) 2012-2014 by Marijn Haverbeke <marijnh@gmail.com> | |||
Copyright (C) 2014 by Ingvar Stepanyan <me@rreverser.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you okay with a copyright by Marijn Haverbeke and others
combined with an AUTHORS
file (generated from the git history) that lists all individual contributors, re-generated on every release? Adding everyone to LICENSE
individually by hand is going to A) create a noisy license, and B) produce a lot of commit noise.
Awesome work. See my nitpicks in the comments. (I don't expect you to fix the license thing, I just want your feedback -- I have a similar set-up to generate an AUTHORS file in CodeMirror, and can easily copy that to this repo.) One thing I was wondering about is why the template string tokenizing is integrated with the normal tokenizing. Wouldn't it make more sense to branch right at the start of Are you interested in updating |
Was thinking about this, but figured out that it might produce more abstractions where it's not really needed since templates are pretty much like strings, special characters should be treated in the same way and the only differences are 1) not skipping spaces and 2) stopping on
I'll definitely add types to |
I've merged this. Champagne all around. Next time, observe the standard git commit message style where you put a short message (<80chars preferably) at the top line, followed by a blank line, and then further details. That way, tools that summarize the commits won't show huge long lines of text (they'll include anything up to the first empty line). Please create new pull requests for further changes. |
There appears to still be a problem with the Travis setup. I haven't looked into it yet. |
Looks like you just didn't turn on support for this repo on the Travis side. |
Could you please fix project name in AUTHORS file? |
Done and done. Though Travis seems to be hung on a slow NPM download or something like that. |
Yeah, it has kind of significant delays on free repos, but still better that nothing. |
Working features:
\u{ABCDEF}
).for (... of ...)
loops.Closes #78.