-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DT-593: Codesniffing via pre-commit hook does not respect filesets #3448
Comments
It seems like the Twig validator handles this okay by using FilesetManager::filterFilesByFileset(), maybe replicate that pattern. |
To be more specific, the problem here is when you've dirtied a versioned file that isn't specifically excluded by phpcs.xml. PHPCS won't sniff files that are excluded even when specifically passed as an argument (good), but it will sniff them if they aren't already listed as a |
This is the root cause of numerous other issues, most recently #3366 (which has my thoughts on the issue and some additional background), but also #2879 and others. We should fix it for real.
The text was updated successfully, but these errors were encountered: