Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DT-747: Remove dependency on webflo/drupal-core-require-dev #3838

Closed
danepowell opened this issue Sep 4, 2019 · 0 comments · Fixed by #3908
Closed

DT-747: Remove dependency on webflo/drupal-core-require-dev #3838

danepowell opened this issue Sep 4, 2019 · 0 comments · Fixed by #3908
Labels
Enhancement A feature or feature request

Comments

@danepowell
Copy link
Contributor

We added webflo/drupal-core-require-dev to blt-require-dev (and by extension, the require-dev section of every BLT project's composer.json) in #3065

This has caused a fairly regular spate of issues. For one, it seems to confuse people trying to update Drupal core because they have to whitelist webflo/drupal-core-require-dev along with core if they aren't doing a general composer update.

More recently, it contributed to #3585

More generally, it just seems like an unnecessary set of dependencies for most users, since it's only necessary if you are running Drupal core test suites.

Now that we have a dedicated tests:drupal:run command that the above users running core tests should be using, I think we should remove drupal-core-require-dev as a general dependency and instead dynamically check for and help add it only as part of the tests:drupal:run command.

We'll just need to ensure that any of BLT's core dependencies are replicated outside of the webflo package. And we need to consider if this can be done in a BC way.

@danepowell danepowell added the Enhancement A feature or feature request label Sep 4, 2019
@danepowell danepowell added this to the Backlog milestone Sep 4, 2019
@danepowell danepowell changed the title Remove dependency on webflo/drupal-core-require-dev DT-747: Remove dependency on webflo/drupal-core-require-dev Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant