Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DT-971: Deprecate tests:drupal:run-tests:run #3917

Closed
danepowell opened this issue Nov 13, 2019 · 2 comments · Fixed by #3931
Closed

DT-971: Deprecate tests:drupal:run-tests:run #3917

danepowell opened this issue Nov 13, 2019 · 2 comments · Fixed by #3931
Labels
11.x Affects or applies to 11.x

Comments

@danepowell
Copy link
Contributor

danepowell commented Nov 13, 2019 •
edited
Loading

Drupal core has deprecated simpletest, which is what the run-tests.sh script relies on. It also causes frequent problems for us in terms of automated testing, most recently #3916. I think these issues are exacerbated by the fact that no one really uses simpletest these days, so it's brittle and we are usually the first ones to catch new issues.

Let's add a deprecation notice in 11.x and remove support entirely in 12.x. As an alternative, users should consider tests:drupal:phpunit:run (run core tests via PHPUnit rather than Simpletest).
@danepowell danepowell added 10.x Major change Requires change record (often BC-breaking) 11.x Affects or applies to 11.x labels Nov 13, 2019
@danepowell danepowell changed the title Deprecate tests:drupal:run-tests:run DT-971: Deprecate tests:drupal:run-tests:run Nov 13, 2019
@danepowell danepowell added this to the Backlog milestone Nov 13, 2019
@danepowell
Copy link
Contributor Author

@greylabel do you have any opinions on this, considering you wrote the initial integration? I haven't used simpletest in forever, and consensus seems to be that it's old and janky. But if there's still a huge demand for it or good reason to continue supporting it, I'd like to know.

@danepowell danepowell mentioned this issue Nov 22, 2019
Closed
@danepowell
Copy link
Contributor Author

danepowell commented Nov 22, 2019 •
edited
Loading

The .travis.yml that currently ships with BLT 11 is broken because it tries to run run-tests.sh, which require Selenium, which has been removed. My understanding is that the new core phpunit and nightwatch frameworks use Chrome rather than Selenium by default, so this should naturally resolve itself. But we should make sure to verify that .travis.yml works as shipped.

Replace the call to run-tests with the core phpunit tests instead.

@danepowell danepowell mentioned this issue Nov 22, 2019
Closed
danepowell added a commit to danepowell/blt that referenced this issue Nov 26, 2019
@danepowell
DT-971: Fixes acquia#3917: Deprecate run-tests.sh.
0800ee9
@danepowell danepowell mentioned this issue Nov 26, 2019
Merged
@danepowell danepowell removed the Major change Requires change record (often BC-breaking) label Nov 26, 2019
danepowell added a commit that referenced this issue Nov 26, 2019
@danepowell
DT-971: Fixes #3917: Deprecate run-tests.sh, support Chrome for Drupa…
a90041b 
…l core tests. (#3931)

* DT-971: Fixes #3917: Deprecate run-tests.sh.

* Stop using selenium, support Chrome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
11.x Affects or applies to 11.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DT-971: Fixes #3917: Deprecate run-tests.sh, support Chrome for Drupal core tests. danepowell/blt
1 participant
@danepowell