Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run tests without Selenium installed. #3644

Closed
dpagini opened this issue May 13, 2019 · 7 comments
Closed

Cannot run tests without Selenium installed. #3644

dpagini opened this issue May 13, 2019 · 7 comments
Labels
Enhancement A feature or feature request

Comments

@dpagini
Copy link
Contributor

dpagini commented May 13, 2019

Describe the bug
I want to run Drupal PHPUnit tests with the run-tests.sh method without using selenium. This was introduced in #3577. I'm wondering if there can be a better way to make this work...? I believe Selenium is only required to make the javascript functional tests work, is that accurate? If so, is there anyway we can skip those tests or something if there is no selenium... that would still allow kernel and functional tests to run on a system without selenium. Just seems drastic to say you cant run any tests without Java installed...?

Expected behavior
I want to be able to run tests without Java installed.

@dpagini dpagini added the Bug Something isn't working label May 13, 2019
@greylabel
Copy link
Contributor

@dpagini Just curious, where are you trying to run these tests that does not have Java? Pipelines?

@dpagini
Copy link
Contributor Author

dpagini commented May 14, 2019

Locally and on Travis I don't have java. None of our DEVs have java locally as we all started from a shared base box. We could definitely add it, but I don't need it right now (no functional JS tests) and it's blocking me from upgrading to BLT 10 now.

@greylabel
Copy link
Contributor

Ok, BLT enables Java on both Travis and DrupalVM by default. I will take a look at adding a flag to skip Java dependent tests.

@dpagini
Copy link
Contributor Author

dpagini commented May 14, 2019

This is really a minor one to me... don’t mean to inconvenience, just wanted to mention my experience. I’m psyched to start writing and testing JavaScript tests, so thanks for all you’ve done already!

@greylabel
Copy link
Contributor

I have been meaning find time to add support for Nightwatch.js, which is also supported by Drupal core for JS testing, so it won't be a bother to revisit this in the process.

@danepowell
Copy link
Contributor

Thanks, if you're able to spearhead this it would be much appreciated. It would be a big lift for me since I don't work with the core testing framework on a regular basis. I do agree that long-term, it would be good to support environments without Java.

@danepowell danepowell added Enhancement A feature or feature request and removed Bug Something isn't working labels May 15, 2019
@danepowell danepowell added this to the 10.2.0 milestone May 15, 2019
@danepowell
Copy link
Contributor

danepowell commented Nov 22, 2019

The original request here is in the context of the run-tests.sh script, which we are considering deprecating in BLT 11 (because Simpletest itself is becoming deprecated in Drupal): #3917

We've already removed Selenium from BLT by default (#3878), and are in the process of reworking the Drupal test commands to use (PHPUnit or Nightwatch) and Chromedriver by default: #3673

In that case, it doesn't seem like there's any action required in this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

No branches or pull requests

3 participants