Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to skip the BLT alias #4218

Closed
benjifisher opened this issue Jul 29, 2020 · 2 comments
Closed

Make it possible to skip the BLT alias #4218

benjifisher opened this issue Jul 29, 2020 · 2 comments
Labels
Enhancement A feature or feature request

Comments

@benjifisher
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I am running BLT from a Docker container, using Lando. I have told Lando to use /app/vendor/bin/blt as the executable, so I do not need an alias. Yet I still get nuisance warnings:

$ lando blt install
...
> blt:init:shell-alias
[warning] Could not find your CLI configuration file.
[warning] Looked in ~/.zsh, ~/.bash_profile, ~/.bashrc, ~/.profile, and ~/.functions.
[warning] Please create one of the aforementioned files, or create the BLT alias manually.

Describe the solution you'd like

Add an option to blt/blt.yml that lets me skip the blt:init:shell-alias task at the end of blt setup.

Describe alternatives you've considered

I could add ~/.functions or similar to the Docker container, but that seems like fixing the problem in the wrong place. Besides, I still get one line of success noise (green) instead of a few lines of warning noise (yellow).

Additional context

I plan to submit a PR soon.

@danepowell
Copy link
Contributor

danepowell commented Jul 30, 2020

BLT has a built-in mechanism to disable any command, have you tried it? https://docs.acquia.com/blt/extending-blt/#disabling-a-command

It's not mentioned explicitly in the docs but I think in addition to using blt.yml, you can also do this via the CLI: blt setup -D disable-targets.blt.shell-alias.init=true

If that works maybe we need to link to the docs from the warning message like we do for Git hooks.

@danepowell danepowell added the Awaiting response Maintainer needs more info label Jul 30, 2020
@benjifisher
Copy link
Contributor Author

@danepowell:

Thanks for the link to the docs. It works as expected.

I did not test adding the option at the CLI.

For the record, I added these lines to blt/blt.yml:

disable-targets:
  blt:
    shell-alias:
      init: true

Adding a link to the docs might help. OTOH, an extra line in the annoying warning message would make it even more annoying. Maybe adding an item to https://docs.acquia.com/blt/install/next-steps/ would be a better idea.

@no-response no-response bot removed the Awaiting response Maintainer needs more info label Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement A feature or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants