Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on individual event page #223

Open
harumijang opened this issue Feb 28, 2023 · 0 comments
Open

Error on individual event page #223

harumijang opened this issue Feb 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@harumijang
Copy link
Contributor

harumijang commented Feb 28, 2023

Describe the bug
App errors on when visiting an individual event page. After some digging my guess is that the image style source data structure changed upstream and the code in media--image.tsx is now looking for a key that doesn't exist.

Inside of starters/basic-starter/components/media--image.tsx

  if (imageStyle) {
    if (image.links) {
      if (image.links[imageStyle]) {
        const imageStyleSource = image.links[imageStyle];
        sizeProps = {
          width: width || imageStyleSource.meta.linkParams.width,
          height: height || imageStyleSource.meta.linkParams.height,
        };

I don't think linkParams exists anymore so it should be removed so now it is imageStyleSource.meta.width and imageStyleSource.meta.height.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any individual event page ex. /event/webinar/2025/01/event-one-medium-length-placeholder-heading or run yarn build on head and it will error out

Screenshots
image

@harumijang harumijang added the bug Something isn't working label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant