Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Drupal's Site Name and Site Slogan in layout.tsx #29

Open
balsama opened this issue Jun 22, 2022 · 2 comments
Open

Use Drupal's Site Name and Site Slogan in layout.tsx #29

balsama opened this issue Jun 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@balsama
Copy link

balsama commented Jun 22, 2022

layout.tsx uses a hard-coded Site Name in the <title> tag and in the page header. Ideally, that would use the value from Drupal's Site Name config. The design should also probably include the site slogan value from Drupal (like most Drupal front-end themes do).

I'm not sure how to get this data out of Drupal though since json:api is strictly entity-based.

@lauriii lauriii added the enhancement New feature or request label Jun 22, 2022
@fiasco
Copy link
Contributor

fiasco commented Jun 27, 2022

There is https://www.drupal.org/project/jsonapi_site but it doesn't look like it uses jsonapi properly so I doubt it will plug into openapi natively. For that reason alone, its not likely we'd add it to Acquia CMS unless its infrastructure changed.

@lauriii
Copy link
Contributor

lauriii commented Jun 29, 2022

I'm wondering if this is one of those features that would be nice for a demo but when people actually build applications, they would just rip it off to reduce complexity. 🤷‍♂️ The site name config in most cases is something that is configured once and then never changed again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants