Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could the search display the number of matches found? #4

Open
UrsaDK opened this issue Jun 10, 2015 · 3 comments
Open

Could the search display the number of matches found? #4

UrsaDK opened this issue Jun 10, 2015 · 3 comments
Assignees

Comments

@UrsaDK
Copy link

UrsaDK commented Jun 10, 2015

Not a bug, but more of a feature request...

It would be really handy if the new search introduced in v1.7 (which is absolutely awesome and beats the pants off the default search!!) could display the number of matches found as well as the count of the currently highlighted item. There appears to be enough space at the top-left corner of the search box to put something like: 1 of 6 matches or Not found, which would keep it consistent with the reporting used by the default search.

@acrogenesis
Copy link
Owner

This will take me more time than the last fix 😁. The editor JSONace uses is https://github.com/ajaxorg/ace if you want check their repo out, if you find how to do it I'll gladly accept the PR.

@acrogenesis
Copy link
Owner

I've opened an issue over there ajaxorg/ace#2539

@UrsaDK
Copy link
Author

UrsaDK commented Jun 11, 2015

Thanks @acrogenesis! :) Unfortunate, I'm a bit swamped with work at the moment so the likelihood of me finding the time to fiddle with ace is a bit slim, so let's hope ajaxorg guys respond to the issue you've opened!

PS: … but just in case I do find the time to play with ace, I most certainly will send you a PR! :)

@acrogenesis acrogenesis self-assigned this Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants