Rule update: "aria-hidden with focusable content" #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"focusable" --> "Participate in sequential focus navigation", "contain" --> "have descendants in the flat tree"
annethyme
added
Rule Update
This was referenced Mar 14, 2019
annethyme
requested review from
audreymaniez,
ShadowBB,
jeeyyy and
DagfinnRomen
kasperisager
previously requested changes
Mar 18, 2019
_rules/SC4-1-2-aria-hidden-focus.md
Outdated
| @@ -26,7 +26,7 @@ The rule applies to any element with an `aria-hidden="true"` attribute. | |||
|
|
|||
| ### Expectation | |||
|
|
|||
| None of the target elements are [focusable](#focusable), nor do they contain a [focusable element](#focusable). | |||
| None of the target elements participate in [sequential focus navigation](https://www.w3.org/TR/html/editing.html#sec-sequential-focus-navigation), nor do they have [descendants](https://www.w3.org/TR/dom41/#concept-tree-descendant) in the [flat tree](https://drafts.csswg.org/css-scoping/#flat-tree) that participate in [sequential focus navigation](https://www.w3.org/TR/html/editing.html#sec-sequential-focus-navigation) | |||
There was a problem hiding this comment.
Missing stop at the end.
kasperisager
approved these changes
Mar 18, 2019
audreymaniez
approved these changes
Mar 19, 2019
ShadowBB
approved these changes
Mar 19, 2019
annethyme
changed the title
|
@audreymaniez, @JKODU, @kasperisager, @ShadowBB: After some internal discussions, I have added a test case with tabindex="-2". I hope you can still approve. |
annethyme
requested review from
kasperisager,
audreymaniez,
ShadowBB and
jeeyyy
and removed request for
audreymaniez,
kasperisager,
ShadowBB and
jeeyyy
carlosapaduarte
previously requested changes
Mar 23, 2019
kasperisager
approved these changes
Mar 24, 2019
annethyme
dismissed
carlosapaduarte’s stale review
Typo fixed. Please review again.
annethyme
added
Review call 2 weeks
WilcoFiers
approved these changes
Mar 27, 2019
|
@DagfinnRomen, #439 and #449 solve two different issues for the same rule. They should not be seen as competing suggestions. In an ideal world, it would have been great if they were handled together, but since there are no conflicts between the two, I think it works fine to review and merge them separately. |
|
@WilcoFiers, I have changed "participate in [sequential focus navigation]" to "are part of [sequential focus navigation]" in hope to make it a bit easier to read. |
* master: Rule update: "HTML page has a title" (#440) Rule update: "aria attribute allowed" and "aria required states and properties" (#436) Changed succescriteria from 4.1.2 to 1.3.1 (#449) Rename SC1-2-Video-description-track.md to SC1-2-video-description-track.md Glossary: add "Accessibility Support" to "Semantic role" term (#442) SC1-1-1-filename-is-valid-accessible-name (#263) Added assumption for SC3-1-2-lang-valid (#413) Update SC4-1-1-unique-id.md fix: update applicability fix: revert definitions fix: update glossary fix: applicability
kasperisager
added a commit
that referenced
this pull request
Apr 26, 2019
* develop: (76 commits) Update SC1-1-1-image-has-name.md (#468) chore: update test case names to be hash and not have outcome (#485) chore: update styles chore: fix styling and spacing on various resolutions chore: fix typo in rules chore: update dependencies chore: add unique id to all rules (#478) fix: move footer from nav fix: update cache version fix: bust dependency cache chore: WCAG ACT RULES CG Website Update (#437) chore: update site publish config Replace auto-wcag with act-r in readme Update _config.yml Rule update: "aria-hidden with focusable content" (#439) Rule update: "HTML page has a title" (#440) Rule update: "aria attribute allowed" and "aria required states and properties" (#436) Changed succescriteria from 4.1.2 to 1.3.1 (#449) Rename SC1-2-Video-description-track.md to SC1-2-video-description-track.md Glossary: add "Accessibility Support" to "Semantic role" term (#442) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"focusable" --> "Participate in sequential focus navigation"
Closes issues:
aria-hiddenelements not participate in sequential focus navigation order rather than be not focusable? #374 (Should "Aria-hidden with focusable content" require thataria-hiddenelements not participate in sequential focus navigation order rather than be not focusable?)"contain" --> "have descendants in the flat tree"
Closes issue:
How to Review And Approve