Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary: add "Accessibility Support" to "Semantic role" term #442

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

annethyme
Copy link
Collaborator

Closes issue: #214 ("Semantic role" does not specify case-sensitivity)

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.


Some browsers and assistive technologies treat the tokens of the `role` attribute as case-sensitive. Unless lowercase letters are used for the value of the `role` attribute, not all user agents will be able to interprete the tokens correctly. ARIA in HTML also specifies that [authors must use lowercase letters for the `role` and `aria-*` attributes](https://www.w3.org/TR/html-aria/#case-sensitivity).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"interprete" -> "interpret".

@annethyme annethyme changed the title Update semantic-role.md Glossary: add "Accessibility Support" to "Semantic role" term Mar 18, 2019
Rules Progress automation moved this from Needs Review to CFC (Reviewer Approved) Mar 19, 2019
@annethyme
Copy link
Collaborator Author

@WilcoFiers, are you okay with me merging this one instead of sending it out in a "Final call"?

In my write-up of our conversation earlier, #463, changes to "accessibility support" is mentioned as something that does not require a "Final call".

@annethyme
Copy link
Collaborator Author

Merging this change and re-publishing the glossary term without a "Final call" stage, since this change will not directly change the outcome of any rules.

@annethyme annethyme merged commit 5df8760 into master Mar 26, 2019
Rules Progress automation moved this from CFC (Reviewer Approved) to Done Mar 26, 2019
kasperisager added a commit that referenced this pull request Apr 10, 2019
* master:
  Rule update: "HTML page has a title" (#440)
  Rule update: "aria attribute allowed" and "aria required states and properties" (#436)
  Changed succescriteria from 4.1.2 to 1.3.1 (#449)
  Rename SC1-2-Video-description-track.md to SC1-2-video-description-track.md
  Glossary: add "Accessibility Support" to "Semantic role" term (#442)
  SC1-1-1-filename-is-valid-accessible-name (#263)
  Added assumption for SC3-1-2-lang-valid (#413)
  Update SC4-1-1-unique-id.md
  fix: update applicability
  fix: revert definitions
  fix: update glossary
  fix: applicability
kasperisager added a commit that referenced this pull request Apr 26, 2019
* develop: (76 commits)
  Update SC1-1-1-image-has-name.md (#468)
  chore: update test case names to be hash and not have outcome (#485)
  chore: update styles
  chore: fix styling and spacing on various resolutions
  chore: fix typo in rules
  chore: update dependencies
  chore: add unique id to all rules (#478)
  fix: move footer from nav
  fix: update cache version
  fix: bust dependency cache
  chore: WCAG ACT RULES CG Website Update (#437)
  chore: update site publish config
  Replace auto-wcag with act-r in readme
  Update _config.yml
  Rule update: "aria-hidden with focusable content" (#439)
  Rule update: "HTML page has a title" (#440)
  Rule update: "aria attribute allowed" and "aria required states and properties" (#436)
  Changed succescriteria from 4.1.2 to 1.3.1 (#449)
  Rename SC1-2-Video-description-track.md to SC1-2-video-description-track.md
  Glossary: add "Accessibility Support" to "Semantic role" term (#442)
  ...
@Jym77 Jym77 deleted the update-glossary-semantic-role branch July 24, 2019 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Rules Progress
  
Published
Development

Successfully merging this pull request may close these issues.

None yet

5 participants