Changed succescriteria from 4.1.2 to 1.3.1 #449

danistr · 2019-03-19T11:40:34Z

<< Describe the changes >>

Closes issue: (#448 )

Guidance for the PR (pull request) creator

When creating PR:

Make sure you requesting to pull a issue/feature/bugfix branch (right side) to the master branch (left side).

After creating PR:

Add yourself (and co-authors) as "Assignees" for PR
Add label to indicate if it's a Rule, Definition or Chore (more to the administrative side)
Add relevant project (e.g. "Q3 2018 Status") to PR
OPTIONAL: If you want anyone in particular to review your pull request, assign them as "Reviewers".
Close the issue that the PR resolves (and make sure the issue is referenced in the top of this comment)

How to Review And Approve

Go to the “Files changed” tab
Here you will have the option to leave comments on different lines.
Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.

annethyme

I tried to come up with an example, where it wouldn't fall under 1.3.1, but didn't succeed, so if no one else comes up with anything either, I approve this rule.

carlosapaduarte

In the applicability's note there's a typo: change decendent to descendent

annethyme · 2019-03-20T09:56:11Z

@JKODU, I am assigning you to this one, since you are the person responsible for this rule within the WAI-Tools project.

ShadowBB · 2019-03-20T10:22:51Z

In the applicability's note there's a typo: change decendent to descendent

Done. Thanks!

DagfinnRomen · 2019-03-25T10:03:08Z

The background section should reference the 1.3.1 understanding article, not 4.1.2.
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

Also, I suggest a minor update to the description, from "This rule checks aria-hidden elements do not contain focusable elements" to "This rule checks that elements with an aria-hidden attribute do not contain focusable elements".

Reworded the description somewhat and removed a 4.1.2 references and replaced it with a 1.3.1 reference.

ShadowBB · 2019-03-26T12:55:06Z

The background section should reference the 1.3.1 understanding article, not 4.1.2.
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships.html

Also, I suggest a minor update to the description, from "This rule checks aria-hidden elements do not contain focusable elements" to "This rule checks that elements with an aria-hidden attribute do not contain focusable elements".

Well spotted! Both done. Thanks!

WilcoFiers

I understand the argument for this being a failure of 4.1.2, but I don't quite understand the argument for why this wouldn't also be a failure for 4.1.2. Can someone explain this before we merge? I think at least it needs to be documented somewhere.

ShadowBB · 2019-03-28T11:40:58Z

I understand the argument for this being a failure of 4.1.2, but I don't quite understand the argument for why this wouldn't also be a failure for 4.1.2. Can someone explain this before we merge? I think at least it needs to be documented somewhere.

Sure. This rule checks that elements with an aria-hidden attribute do not contain focusable elements. Elements with an aria-hidden element that contain focusable elements can still have a name and role that can be programmatically determined which is all that is needed to pass 4.1.2 in some cases. So failing this rule is not a guarantee that 4.1.2 also fails.

WilcoFiers · 2019-03-29T09:14:02Z

@ShadowBB Thanks for clarifying. I don't agree with you on this. Putting aria-hidden=true on an element removes it from the accessibility tree. Since the name / role / value props are derived from the accessibility tree, any element with aria-hidden=true no longer has a name, role, or any props / state. And since it is focusable (thus will be perceived by the user as an interface component), I would say that fails SC 4.1.2.

ShadowBB · 2019-03-29T11:13:01Z

@ShadowBB Thanks for clarifying. I don't agree with you on this. Putting aria-hidden=true on an element removes it from the accessibility tree. Since the name / role / value props are derived from the accessibility tree, any element with aria-hidden=true no longer has a name, role, or any props / state. And since it is focusable (thus will be perceived by the user as an interface component), I would say that fails SC 4.1.2.

I have thought about this further and deliberated with a colleague. We came to the conclusion that you are correct. It should indeed fail both SC. Our flaw was in the programmatically determined definition (we forgot that mentioned in needed to be visible to assistive technology too).

Sorry to waste all this time on this. We should probably mention both SC, also in the background.

I now agree with Wilco that it should mention both SC.

audreymaniez · 2019-04-04T05:26:20Z

_rules/SC1-3-1-aria-hidden-focus.md

@@ -42,7 +43,7 @@ By adding `aria-hidden="true"` to an element, content authors ensure that assist

 A focusable element with `aria-hidden="true"` is ignored as part of the reading order, but still part of the focus order, making it's state of visible or hidden unclear.

- https://www.w3.org/WAI/WCAG21/Understanding/name-role-value.html


If both SCs are concerned, put the 4.1.2 link back in the background section :-)

annethyme · 2019-04-05T10:17:38Z

@JKODU, this was actually out in a 2-week "Final Call" that doesn't end until April 9.

* master: Rule update: "HTML page has a title" (#440) Rule update: "aria attribute allowed" and "aria required states and properties" (#436) Changed succescriteria from 4.1.2 to 1.3.1 (#449) Rename SC1-2-Video-description-track.md to SC1-2-video-description-track.md Glossary: add "Accessibility Support" to "Semantic role" term (#442) SC1-1-1-filename-is-valid-accessible-name (#263) Added assumption for SC3-1-2-lang-valid (#413) Update SC4-1-1-unique-id.md fix: update applicability fix: revert definitions fix: update glossary fix: applicability

* develop: (76 commits) Update SC1-1-1-image-has-name.md (#468) chore: update test case names to be hash and not have outcome (#485) chore: update styles chore: fix styling and spacing on various resolutions chore: fix typo in rules chore: update dependencies chore: add unique id to all rules (#478) fix: move footer from nav fix: update cache version fix: bust dependency cache chore: WCAG ACT RULES CG Website Update (#437) chore: update site publish config Replace auto-wcag with act-r in readme Update _config.yml Rule update: "aria-hidden with focusable content" (#439) Rule update: "HTML page has a title" (#440) Rule update: "aria attribute allowed" and "aria required states and properties" (#436) Changed succescriteria from 4.1.2 to 1.3.1 (#449) Rename SC1-2-Video-description-track.md to SC1-2-video-description-track.md Glossary: add "Accessibility Support" to "Semantic role" term (#442) ...

Changed succescriteria from 4.1.2 to 1.3.1

2200b95

ShadowBB requested review from annethyme, carlosapaduarte, DagfinnRomen and jeeyyy March 19, 2019 12:12

ShadowBB previously approved these changes Mar 19, 2019

View reviewed changes

annethyme approved these changes Mar 19, 2019

View reviewed changes

carlosapaduarte approved these changes Mar 19, 2019

View reviewed changes

annethyme mentioned this pull request Mar 20, 2019

aria-hidden with focusable content fails the wrong succescriterium #448

Closed

annethyme assigned jeeyyy Mar 20, 2019

annethyme added Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already March 31 deadline labels Mar 20, 2019

annethyme added this to Needs Review in Rules Progress via automation Mar 20, 2019

annethyme assigned danistr Mar 20, 2019

annethyme added the Agenda item label Mar 20, 2019

Typo: "decendent" to "descendent"

5d8d70d

DagfinnRomen mentioned this pull request Mar 25, 2019

Rule update: "aria-hidden with focusable content" #439

Merged

Minor background and description change

28e119f

Reworded the description somewhat and removed a 4.1.2 references and replaced it with a 1.3.1 reference.

annethyme added Review call 2 weeks Call for review for new rules and big changes and removed Agenda item labels Mar 26, 2019

WilcoFiers requested changes Mar 27, 2019

View reviewed changes

ShadowBB requested a review from WilcoFiers March 28, 2019 11:41

aria-hidden-focus: Still test 4.1.2

df2a6f5

Rules Progress automation moved this from Needs Review to CFC (Reviewer Approved) Apr 1, 2019

WilcoFiers approved these changes Apr 1, 2019

View reviewed changes

annethyme approved these changes Apr 1, 2019

View reviewed changes

ShadowBB approved these changes Apr 1, 2019

View reviewed changes

audreymaniez reviewed Apr 4, 2019

View reviewed changes

Update SC1-3-1-aria-hidden-focus.md

62a3757

jeeyyy merged commit 8fc9fff into act-rules:master Apr 5, 2019

Rules Progress automation moved this from CFC (Reviewer Approved) to Done Apr 5, 2019

annethyme removed this from Published in Rules Progress Jul 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changed succescriteria from 4.1.2 to 1.3.1 #449

Changed succescriteria from 4.1.2 to 1.3.1 #449

danistr commented Mar 19, 2019

annethyme left a comment

carlosapaduarte left a comment

annethyme commented Mar 20, 2019

ShadowBB commented Mar 20, 2019

DagfinnRomen commented Mar 25, 2019

ShadowBB commented Mar 26, 2019

WilcoFiers left a comment

ShadowBB commented Mar 28, 2019

WilcoFiers commented Mar 29, 2019

ShadowBB commented Mar 29, 2019

audreymaniez Apr 4, 2019

annethyme commented Apr 5, 2019

		@@ -42,7 +43,7 @@ By adding `aria-hidden="true"` to an element, content authors ensure that assist

		A focusable element with `aria-hidden="true"` is ignored as part of the reading order, but still part of the focus order, making it's state of visible or hidden unclear.

		- https://www.w3.org/WAI/WCAG21/Understanding/name-role-value.html

Changed succescriteria from 4.1.2 to 1.3.1 #449

Changed succescriteria from 4.1.2 to 1.3.1 #449

Conversation

danistr commented Mar 19, 2019

Guidance for the PR (pull request) creator

How to Review And Approve

annethyme left a comment

Choose a reason for hiding this comment

carlosapaduarte left a comment

Choose a reason for hiding this comment

annethyme commented Mar 20, 2019

ShadowBB commented Mar 20, 2019

DagfinnRomen commented Mar 25, 2019

ShadowBB commented Mar 26, 2019

WilcoFiers left a comment

Choose a reason for hiding this comment

ShadowBB commented Mar 28, 2019

WilcoFiers commented Mar 29, 2019

ShadowBB commented Mar 29, 2019

audreymaniez Apr 4, 2019

Choose a reason for hiding this comment

annethyme commented Apr 5, 2019