Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an empty value to be specified for jobs.<id>.container #265

Closed
ericsciple opened this issue Jan 12, 2020 · 3 comments · Fixed by #266
Closed

Allow an empty value to be specified for jobs.<id>.container #265

ericsciple opened this issue Jan 12, 2020 · 3 comments · Fixed by #266
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ericsciple
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

I'd like to be able to build a matrix workflow where some jobs run in a container and some run directly on the VM. I may have a cross-platform tool where I have strange dependencies that I provide via a container, or I want to run on multiple different Linux distributions, but also run on Windows and macOS. So I would like a way to specify that I run on no container. This would allow me to create a workflow like:

name: CI

on: [push]

jobs:    
  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        image: ['ubuntu:latest', 'centos:latest', '']

A more realistic scenario would be a matrix of runs-on that includes linux, windows and macos, and then includeing the container value on linux hosts.

Describe the solution you'd like
That some value exists for container that means "none". Perhaps: an empty string (''), a dash ('-'), or a dot ('.'), all of which are not legal image names.

@ericsciple ericsciple added the enhancement New feature or request label Jan 12, 2020
@ericsciple ericsciple assigned ethomson and ericsciple and unassigned ethomson Jan 12, 2020
@ericsciple
Copy link
Collaborator Author

@ethomson fyi i moved the issue here

@ericsciple
Copy link
Collaborator Author

Fixed on the runner (expression scenario). Still need to fix on the server (non-expression)

@mnishamk-freiheit
Copy link

mnishamk-freiheit commented Jul 25, 2022

could this be done for jobs.<id>.container.image as well?

ie support the use of private images or no images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants