Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand current syntax to support aliases for latest version (current/latest/node) #483

Merged
merged 23 commits into from May 12, 2022

Conversation

panticmilos
Copy link
Contributor

@panticmilos panticmilos commented May 4, 2022

Description:
This PR contains changes needed to support installing the latest node version from the distribution with multiple aliases. It also contains unit, e2e tests, and expanded documentation.

Related issue:
#418, #471

Check list:

  • [ x ] Mark if documentation changes are required.
  • [ x ] Mark if tests were added or updated to cover the changes.

@panticmilos panticmilos requested a review from a team as a code owner May 4, 2022
@vsafonkin
Copy link
Contributor

vsafonkin commented May 4, 2022

@panticmilos, please update PR title to be more readable :)

@panticmilos panticmilos changed the title V mpantic/add latest alias Expand current syntax to support aliases for latest version (current/latest/node) May 4, 2022
.github/workflows/versions.yml Outdated Show resolved Hide resolved
src/installer.ts Outdated
@@ -7,6 +7,7 @@ import * as tc from '@actions/tool-cache';
import * as path from 'path';
import * as semver from 'semver';
import fs = require('fs');
import * as installer from './installer';
Copy link
Contributor

@IvanZosimov IvanZosimov May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest omitting this import statement.

src/installer.ts Outdated
@@ -371,7 +372,16 @@ async function queryDistForMatch(
}

let versions: string[] = [];
let nodeVersions = await getVersionsFromDist();
let nodeVersions = await installer.getVersionsFromDist();
Copy link
Contributor

@IvanZosimov IvanZosimov May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we omit the import statement above, we can omit that also:

Suggested change
let nodeVersions = await installer.getVersionsFromDist();
let nodeVersions = await getVersionsFromDist();

@dmitry-shibanov dmitry-shibanov merged commit 17f8bd9 into actions:main May 12, 2022
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants