Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create missing pypyX.Y symlinks #347

Merged
merged 1 commit into from Apr 28, 2022

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Mar 5, 2022

Description:
Create missing pypyX.Y symlinks:
pypyX.Y.exe executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9)
pypy2.7 symlinks are also missing from macOS/Linux PyPy archives before v7.3.9

Related issue:
relates to #346

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@mayeut
Copy link
Contributor Author

@mayeut mayeut commented Mar 5, 2022

Before the PR, tests are failing for Windows only (3.Y tests there) when trying to use pypyX.Y: https://github.com/mayeut/packaging/actions/runs/1937384250

After the PR, tests are passing:
https://github.com/mayeut/packaging/actions/runs/1938654790

@mayeut mayeut marked this pull request as draft Apr 2, 2022
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented Apr 2, 2022

let's go back to draft until PyPy 7.3.9 rollout is complete on GHA hosted runners.

@mayeut mayeut force-pushed the install-pypyX.Y-symlinks branch from e621a16 to 156f48c Compare Apr 2, 2022
`pypyX.Y.exe` executables are missing from PyPy archives on Windows before v7.3.9 (X.Y < 3.9)
`pypy2.7` symlinks are also missing from macOS/Linux PyPy archives before v7.3.9

relates to actions#346
@mayeut mayeut force-pushed the install-pypyX.Y-symlinks branch from 156f48c to 8d0fdb2 Compare Apr 9, 2022
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented Apr 9, 2022

PyPy 7.3.9 rollout is now complete on GHA hosted runners.

@mayeut mayeut marked this pull request as ready for review Apr 9, 2022
@mayeut mayeut requested a review from as a code owner Apr 9, 2022
@mayeut
Copy link
Contributor Author

@mayeut mayeut commented Apr 28, 2022

@marko-zivic-93, @dmitry-shibanov,

anything else I need to do to get this moving forward ? This PR is a pre-requisite for #346 & #349.

@brcrista brcrista merged commit 1ce3088 into actions:main Apr 28, 2022
96 checks passed
@mayeut mayeut deleted the install-pypyX.Y-symlinks branch Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants