Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): update all failing workflows #863

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented May 9, 2024

Description:

With macos-latest moving to macos-14, most workflows are currently failing. Update them to be able to run on macos-latest

Don't test python 3.5 on ubuntu. It's been EOL for almost 4 years and there are now some certificate issues with pip.

fix #891

@mayeut mayeut requested a review from a team as a code owner May 9, 2024 16:23
@mayeut
Copy link
Contributor Author

mayeut commented Jun 12, 2024

please do note that since the PR was opened, #866 & #868 have been opened.
So while this PR removes testing 3.5 as mentioned in the description, maintainers here shall take action to re-add tests once those issues are fixed (or not if triaged to "won't fix").

@priya-kinthali
Copy link
Contributor

Hello @mayeut 👋
Could you please also remove the setup and verification steps for Python EOL versions (3.5, 3.6 and 3.7)? This will help us keep the testing framework up to date with currently supported Python versions. Thanks again for your work on this.

@mayeut
Copy link
Contributor Author

mayeut commented Jun 22, 2024

hello @priya-kinthali,

Could you please also remove the setup and verification steps for Python EOL versions (3.5, 3.6 and 3.7)?

done

@priya-kinthali
Copy link
Contributor

Hello @mayeut 👋,
Thanks for your prompt response and for making the requested changes😊
Could you kindly extend your contribution by including the latest Python versions in test workflows(for eg. e2e-tests.yml)? This would aid in ensuring that our tests are running on the most current versions of Python.

Your diligent efforts are deeply appreciated:)

@mayeut
Copy link
Contributor Author

mayeut commented Jun 24, 2024

Could you kindly extend your contribution by including the latest Python versions in test workflows(for eg. e2e-tests.yml)?

They are already tested in .github/workflows/test-python.yml check-latest job

@priya-kinthali
Copy link
Contributor

They are already tested in .github/workflows/test-python.yml check-latest job.

You're right, the latest Python versions are indeed tested in the test-python.yml workflow. However, we also want to ensure that our end-to-end tests in e2e-tests.yml are kept up-to-date and are running on the most recent Python versions as well. Could you please include the latest Python versions in the e2e-tests.yml file too. Thanks!

With `macos-latest` moving to `macos-14`, most workflows are currently failing.
Update them to be able to run on `macos-latest`

Don't test python 3.5 on ubuntu. It's been EOL for almost 4 years and there are now some certificate issues with pip.
@HarithaVattikuti HarithaVattikuti merged commit a0d74c0 into actions:main Jun 27, 2024
258 checks passed
@mayeut mayeut deleted the update-workflows branch June 27, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup-python CI workflows have been broken for more than 2 months
6 participants