NOT Closing issues / PRs immediately after adding the 'stale' label

[xakraz]

Hi there,

I have a comment related the issue #28.

🙏 for having implemented this a few days ago, but I am looking for the old behavior 😅

We are introducing this action on many repos that have stale issues for a very long time.
So I was expecting the behavior as it is sated in the configuration :

days-before-close:
    description: 'The number of days to wait to close an issue or pull request after it being marked stale. Set to -1 to never close stale issues.'
    default: 7

1. Mark the issue as stale and post a comment, which notifies the author.
2. Then, after days-before-close close the PR that has been marked stale,

Would there be a way to get both behavior ?
May as @NBprojekt suggested with a value of 0 ?

Thanks again for your work 😄

[carterbox]

I have the same problem! I enabled this action on my repository and a bunch of old issues were closed immediately when I had set days-before-close to 7, but I was expecting them to only be marked as stale and closed next week!

[hross]

sorry about this. I will go back and validate the old behavior but I think all you need to do is set days before close to the number of total days before close (not additive to the stale count). this may be a bug in v3. I'll check it out.

[hross]

this looks like a bug in the intended behavior since... forever?

Looking at v1 I see the same behavior: https://github.com/actions/stale/blob/v1/src/main.ts but the configuration examples still seem to indicate it should not function that way. Hard to believe no one noticed the bug? Either way I'll fix it and republish a new version

[LaurenceGA]

It hasn't been happening prior to v3 though 🤷 Just started after upgrading for me at least.
It's not related to #64?

[hross]

I'm not sure. It would presumably close the issue the next time it ran, rather than right at the stale time. I just pushed a change to fix the behavior though so let me know if that fixes it (if you are pinned to v3 you'll get the fix).