Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This action closed half of my issue instead of only marking them as stale #76

Closed
HarelM opened this issue May 20, 2020 · 3 comments
Closed

Comments

@HarelM
Copy link

HarelM commented May 20, 2020

I have yesterday added this action to my project.
The flow ran tonight and closed half of my issues.
They were stale, but instead of only marking as stale and wait a week it closed it immediately.
This seems like a critical bug to me.
See here:
https://github.com/IsraelHikingMap/Site/blob/master/.github/workflows/stale.yml
https://github.com/IsraelHikingMap/Site/issues?q=is%3Aissue+is%3Aclosed+sort%3Aupdated-desc

@hross
Copy link
Contributor

hross commented May 26, 2020

The issue here seems to be that your workflow file is defining closed days as "in addition to" stale days. The bot used to interpret closed days independently of stale days, so 7 would mean "close issues after 7 days if they are marked stale".

I recently changed the behavior because it's confusing. The bot will now only close issues after 97 days (as you intended) but you installed it before that update.

I also added more logging by default in case unexpected behavior happens in the future, so you will be able to point to the logs and see why the bot did what it did.

Apologies for the confusing behavior here. Please let me know if you have any further issues in the new runs.

@hross
Copy link
Contributor

hross commented May 26, 2020

Fixed logging in: #83

@hross hross closed this as completed May 26, 2020
@HarelM
Copy link
Author

HarelM commented May 26, 2020

Thanks for the info. Do I need to do something in order to get the latest version?
Also, just to make sure, If I add a stale tag manually, will this bot close the issue after 7 days and not just after 97? Also removing the stale label is defined as "touching" the issue so that it won't close?
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants