Fix Comments controller destroy declaration (#6482)

* Fix the comments controller methods

The destroy was defined in the create method 🤪

* Add tests for full coverage

---------

Co-authored-by: Javier Julio <jjfutbol@gmail.com>

lib/active_admin/orm/active_record/comments.rb

@@ -72,15 +72,15 @@ def create
               redirect_back fallback_location: active_admin_root
             end
           end
+        end
 
-          def destroy
-            destroy! do |success, failure|
-              success.html do
-                redirect_back fallback_location: active_admin_root
-              end
-              failure.html do
-                redirect_back fallback_location: active_admin_root
-              end
+        def destroy
+          destroy! do |success, failure|
+            success.html do
+              redirect_back fallback_location: active_admin_root
+            end
+            failure.html do
+              redirect_back fallback_location: active_admin_root
             end
           end
         end

spec/unit/resource/comments_spec.rb

@@ -0,0 +1,53 @@
+# frozen_string_literal: true
+require "rails_helper"
+
+RSpec.describe "ActiveAdmin Comments", type: :controller do
+  before do
+    load_resources { ActiveAdmin.register ActiveAdmin::Comment, as: "Comment" }
+    @controller = Admin::CommentsController.new
+  end
+
+  describe "#destroy" do
+    let(:user) { User.create! }
+    let(:comment) { ActiveAdmin::Comment.create!(body: "body", namespace: :admin, resource: user, author: user) }
+
+    context "success" do
+      it "deletes comments and redirects to root fallback" do
+        delete :destroy, params: { id: comment.id }
+
+        expect(response).to redirect_to admin_root_url
+      end
+
+      it "deletes comments and redirects back" do
+        request.env["HTTP_REFERER"] = "/admin/users/1"
+
+        delete :destroy, params: { id: comment.id }
+
+        expect(response).to redirect_to "/admin/users/1"
+      end
+    end
+
+    context "failure" do
+      it "does not delete comment on error and redirects to root fallback" do
+        expect(@controller).to receive(:destroy_resource) do |comment|
+          comment.errors.add(:body, :invalid)
+        end
+
+        delete :destroy, params: { id: comment.id }
+
+        expect(response).to redirect_to admin_root_url
+      end
+
+      it "does not delete comment on error and redirects back" do
+        request.env["HTTP_REFERER"] = "/admin/users/1"
+        expect(@controller).to receive(:destroy_resource) do |comment|
+          comment.errors.add(:body, :invalid)
+        end
+
+        delete :destroy, params: { id: comment.id }
+
+        expect(response).to redirect_to "/admin/users/1"
+      end
+    end
+  end
+end