Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Comments controller destroy declaration #6482

Merged
merged 2 commits into from
May 11, 2023

Conversation

bliof
Copy link
Contributor

@bliof bliof commented Sep 27, 2020

The destroy was defined in the create method 🤪

@deivid-rodriguez
Copy link
Member

Oh wow 😱.

I wonder if the default action is actually working fine, since nobody has actually reported any issues while deleting comments that I recall 🤔.

@javierjulio javierjulio force-pushed the fix-comments-controller-methods branch from 3c08225 to 571a4a5 Compare March 12, 2023 03:09
@javierjulio javierjulio changed the title Fix the comments controller methods Fix the comments destroy controller method declaration Mar 12, 2023
@javierjulio
Copy link
Member

@bliof I tried the update branch feature here but seeing the same code coverage error elsewhere so I think the issue is I can't rebase on my side. Can you please rebase or push an empty commit to re-run CI? I will approve and merge this change once build passes. Thank you.

@javierjulio javierjulio force-pushed the fix-comments-controller-methods branch from 571a4a5 to c6772d5 Compare March 13, 2023 01:19
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.10 🎉

Comparison is base (b42c7f3) 98.84% compared to head (0ee7354) 98.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6482      +/-   ##
==========================================
+ Coverage   98.84%   98.94%   +0.10%     
==========================================
  Files         197      197              
  Lines        4950     4950              
==========================================
+ Hits         4893     4898       +5     
+ Misses         57       52       -5     
Impacted Files Coverage Δ
lib/active_admin/orm/active_record/comments.rb 100.00% <100.00%> (+9.80%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@javierjulio
Copy link
Member

Ok it's been rebased and build is now running. We just need tests to satisfy the Codecov patch check. Would welcome an update. Thank you.

The destroy was defined in the create method 🤪
@javierjulio javierjulio force-pushed the fix-comments-controller-methods branch from c6772d5 to b9cf970 Compare May 11, 2023 02:49
@javierjulio javierjulio self-assigned this May 11, 2023
@javierjulio javierjulio self-requested a review May 11, 2023 04:41
@javierjulio javierjulio changed the title Fix the comments destroy controller method declaration Fix Comments controller destroy declaration May 11, 2023
@javierjulio javierjulio merged commit fc6fd8b into activeadmin:master May 11, 2023
19 checks passed
@bliof bliof deleted the fix-comments-controller-methods branch June 4, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants