-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Comments controller destroy declaration #6482
Fix Comments controller destroy declaration #6482
Conversation
Oh wow 😱. I wonder if the default action is actually working fine, since nobody has actually reported any issues while deleting comments that I recall 🤔. |
3c08225
to
571a4a5
Compare
@bliof I tried the update branch feature here but seeing the same code coverage error elsewhere so I think the issue is I can't rebase on my side. Can you please rebase or push an empty commit to re-run CI? I will approve and merge this change once build passes. Thank you. |
571a4a5
to
c6772d5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6482 +/- ##
==========================================
+ Coverage 98.84% 98.94% +0.10%
==========================================
Files 197 197
Lines 4950 4950
==========================================
+ Hits 4893 4898 +5
+ Misses 57 52 -5
☔ View full report in Codecov by Sentry. |
Ok it's been rebased and build is now running. We just need tests to satisfy the Codecov patch check. Would welcome an update. Thank you. |
The destroy was defined in the create method 🤪
c6772d5
to
b9cf970
Compare
The destroy was defined in the create method 🤪