configure rspec with disable_monkey_patching! #4802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fivell
force-pushed
the
rspec-describe
branch
from
b222539
to
124c163
Compare
|
I think you only need to namespace the outer |
Fivell
force-pushed
the
rspec-describe
branch
from
124c163
to
96b5f47
Compare
|
@deivid-rodriguez , yes wrong regexp ... |
Fivell
force-pushed
the
rspec-describe
branch
from
96b5f47
to
aa7007e
Compare
|
@deivid-rodriguez , rebased and fixed |
spec/unit/application_spec.rb
Outdated
|
|
||
| let(:application) do | ||
| ActiveAdmin::Application.new.tap do |app| | ||
| # Manually override the load paths becuase RSpec messes these up | ||
| # Manually override the load paths becuase RSpec.messes these up |
There was a problem hiding this comment.
Another bad substitution. Maybe you can correct the "becuase" typo since you're here.
| @@ -92,10 +92,10 @@ | |||
| end | |||
| end | |||
| end | |||
| end # describe rendering rows | |||
| end #describe rendering rows | |||
There was a problem hiding this comment.
This line should be left alone.
|
|
||
| end | ||
| end # describe dsl styles | ||
| end #describe dsl styles |
| @@ -232,7 +232,7 @@ | |||
| end | |||
| end | |||
| end | |||
| end # describe rendering rows | |||
| end #describe rendering rows | |||
see https://www.relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/zero-monkey-patching-mode disable all monkey patching done by RSpec
Fivell
force-pushed
the
rspec-describe
branch
from
aa7007e
to
5c579a8
Compare
|
@deivid-rodriguez , thanks ! it was too late for me , sorry for my inattention |
No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://www.relishapp.com/rspec/rspec-core/v/3-0/docs/configuration/zero-monkey-patching-mode
disable all monkey patching done by RSpec