I18n for Comments

[mauriciopasquier]

I wanted to have a default installation (i.e. with comments enabled) translated by default, so I added what was missing.

This repetition:

    comment: "Comment"
    active_admin/comment: "Comment"

is needed because comments_registration_name is Comment so it looks it up without namespace for title and menu translation. The rest is used by filters and scopes generated in the index.

I added hints for i18n-tasks about those ActiveRecord-related strings in the comments file so it can report them as missing when using i18n-tasks missing.

[codecov]

Codecov Report

Merging #5458 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5458   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files         294      294           
  Lines       11050    11050           
=======================================
  Hits        10867    10867           
  Misses        183      183

Impacted Files	Coverage Δ
lib/active_admin/orm/active_record/comments.rb	90.19% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef90f33...75314eb. Read the comment docs.

[mauriciopasquier]

Sorry, I fixed-up and rebased, I had missed some errors before.

[varyonic]

LGTM

[deivid-rodriguez]

Looks great to me too! There's a couple of style things in the PR that we could try to enforce in the future, but we can think about it... in the future. Namely:

• Always keep quoted values in our YAML files. Not very important, but would be nice.
• Make sure we update the i18n hints list when/if new columns are added to the comments table. This happens very rarely, so it does not seem like a big deal.

[mauriciopasquier]

Always keep quoted values in our YAML files. Not very important, but would be nice.

I noticed that style, that's why I changed active_admin.dashboard although it wasn't related to the commit per se. But I'm not sure how to enforce this at code level.

Make sure we update the i18n hints list when/if new columns are added to the comments table. This happens very rarely, so it does not seem like a big deal.

I was hesitant to introduce hints for that reason but I think the pros are enough :)

[deivid-rodriguez]

Thanks so much @mauriciopasquier! ❤️

[mauriciopasquier]

Thank you all for this gem :)