-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18n for Comments #5458
I18n for Comments #5458
Conversation
6fad4b9
to
75314eb
Compare
Codecov Report
@@ Coverage Diff @@
## master #5458 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 294 294
Lines 11050 11050
=======================================
Hits 10867 10867
Misses 183 183
Continue to review full report at Codecov.
|
Sorry, I fixed-up and rebased, I had missed some errors before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me too! There's a couple of style things in the PR that we could try to enforce in the future, but we can think about it... in the future. Namely:
- Always keep quoted values in our YAML files. Not very important, but would be nice.
- Make sure we update the i18n hints list when/if new columns are added to the comments table. This happens very rarely, so it does not seem like a big deal.
I noticed that style, that's why I changed
I was hesitant to introduce hints for that reason but I think the pros are enough :) |
Thanks so much @mauriciopasquier! ❤️ |
Thank you all for this gem :) |
I wanted to have a default installation (i.e. with comments enabled) translated by default, so I added what was missing.
This repetition:
is needed because
comments_registration_name
isComment
so it looks it up without namespace for title and menu translation. The rest is used by filters and scopes generated in the index.I added hints for i18n-tasks about those ActiveRecord-related strings in the comments file so it can report them as missing when using
i18n-tasks missing
.